src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace()#50518
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr.
nodejs-github-bot added c++ 
H4ad approved these changes Nov 2, 2023
H4ad added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Nov 2, 2023
Collaborator
nodejs-github-bot commented Nov 2, 2023
Member
legendecas left a comment
legendecas left a comment There was a problem hiding this comment.
Might be worth adding a cctest to verify DumpJavaScriptBacktrace won't trigger DCHECK when no isolate is entered?
22 tasks
MemberAuthor
Added a cctest |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 3, 2023
H4ad approved these changes Nov 3, 2023
legendecas approved these changes Nov 3, 2023
14 tasks
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 4, 2023
This was referenced Nov 5, 2023
MemberAuthor
joyeecheung commented Nov 6, 2023
Landed in 036c89f with the linter issue fixed. |
joyeecheung added a commit that referenced this pull request Nov 6, 2023
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr. PR-URL: #50518 Refs: #50242 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
This was referenced Nov 7, 2023
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr. PR-URL: nodejs#50518 Refs: nodejs#50242 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr. PR-URL: #50518 Refs: #50242 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
targos pushed a commit that referenced this pull request Nov 14, 2023
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr. PR-URL: #50518 Refs: #50242 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr. PR-URL: #50518 Refs: #50242 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr.
Refs: #50242