tools: compare ICU checksums before file changes#50522
Merged
+7 −7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Otherwise we end up with an bad update PR when checksums don't match. Refs: nodejs#50495
Collaborator
nodejs-github-bot commented Nov 2, 2023
Review requested:
|
marco-ippolito approved these changes Nov 2, 2023
richardlau approved these changes Nov 2, 2023
lpinca approved these changes Nov 3, 2023
marco-ippolito added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 6, 2023
Landed in cde3296 |
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
Otherwise we end up with an bad update PR when checksums don't match. Refs: nodejs#50495 PR-URL: nodejs#50522 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos added a commit that referenced this pull request Nov 11, 2023
Otherwise we end up with an bad update PR when checksums don't match. Refs: #50495 PR-URL: #50522 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos added a commit that referenced this pull request Nov 14, 2023
Otherwise we end up with an bad update PR when checksums don't match. Refs: #50495 PR-URL: #50522 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
Otherwise we end up with an bad update PR when checksums don't match. Refs: #50495 PR-URL: #50522 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we end up with an bad update PR when checksums don't match.
Refs: #50495