Skip to content

test: remove unused file#50528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 10, 2023
Merged

test: remove unused file #50528

nodejs-github-bot merged 1 commit into from
Nov 10, 2023

Conversation

@jsumners
Copy link
Contributor

@jsumnersjsumners commented Nov 2, 2023

This removes a source file that got re-added via a rebase. It seems somewhere around change set
178dff2entry_point.c was removed, and rebase
0b6e16f added it back. The review of #48740 overlooked this and the file got re-committed.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Nov 2, 2023
@jsumnersjsumners changed the title chore: remove unused filesrc: remove unused fileNov 2, 2023
Uzlopak
Uzlopak approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@UzlopakUzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 3, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55432/

vmoroz
vmoroz approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@vmorozvmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tniessen
tniessen approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@tniessentniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix before merging: the subsystem in the commit message is wrong. It should likely be test, not src.

@jsumnersjsumners changed the title src: remove unused filetest: remove unused fileNov 3, 2023
@jsumners
test: remove unused file
69ae652
This removes a source file that got re-added via a rebase. It seems somewhere around change set nodejs@178dff2 `entry_point.c` was removed, and rebase nodejs@0b6e16f added it back. The review of nodejs#48740 overlooked this and the file got re-committed.
@tniessentniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 3, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55437/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55535/

@legendecas
Copy link
Member

legendecas commented Nov 10, 2023•
edited
Loading

https://ci.nodejs.org/job/node-test-commit-aix/48935/ was failing for node-api.test_worker_buffer_callback.test-free-called but I don't think it is related to this PR. Reliability report: https://github.com/nodejs/reliability/issues?q=is%3Aissue+is%3Aopen+test_worker_buffer_callback

@legendecaslegendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-botnodejs-github-bot merged commit 43f5b22 into nodejs:mainNov 10, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2023

Landed in 43f5b22

@jsumnersjsumners deleted the remove-unused-file branch November 10, 2023 17:23
targos pushed a commit that referenced this pull request Nov 11, 2023
@jsumners@targos
test: remove unused file
74a7d47
This removes a source file that got re-added via a rebase. It seems somewhere around change set 178dff2 `entry_point.c` was removed, and rebase 0b6e16f added it back. The review of #48740 overlooked this and the file got re-committed. PR-URL: #50528 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@jsumners@targos
test: remove unused file
2fdcf5c
This removes a source file that got re-added via a rebase. It seems somewhere around change set 178dff2 `entry_point.c` was removed, and rebase 0b6e16f added it back. The review of #48740 overlooked this and the file got re-committed. PR-URL: #50528 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@jsumners@UlisesGascon
test: remove unused file
8a5f36f
This removes a source file that got re-added via a rebase. It seems somewhere around change set 178dff2 `entry_point.c` was removed, and rebase 0b6e16f added it back. The review of #48740 overlooked this and the file got re-committed. PR-URL: #50528 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmorozvmorozvmoroz approved these changes

@lpincalpincalpinca approved these changes

@tniessentniessentniessen approved these changes

@legendecaslegendecaslegendecas approved these changes

+1 more reviewer

@UzlopakUzlopakUzlopak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.node-apiIssues and PRs related to the Node-API.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jsumners@nodejs-github-bot@legendecas@vmoroz@lpinca@tniessen@Uzlopak