doc: correct attribution in v20.6.0 changelog#50564
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JakobJingleheimer added the fast-track 
Contributor
Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve. |
UlisesGascon approved these changes Nov 5, 2023
Member
UlisesGascon left a comment
UlisesGascon left a comment There was a problem hiding this comment.
Not sure why/how I introduced this bug, but thanks for the fix 🙂
MemberAuthor
JakobJingleheimer commented Nov 5, 2023
Cheers! Could you 👍 the fast-track 🙂 |
aduh95 approved these changes Nov 6, 2023
aduh95 added the author ready JakobJingleheimer added commit-queue 
nodejs-github-bot added commit-queue-failed 
Collaborator
nodejs-github-bot commented Nov 6, 2023
Commit Queue failed- Loading data for nodejs/node/pull/50564 ✔ Done loading data for nodejs/node/pull/50564 ----------------------------------- PR info ------------------------------------ Title doc: correct attribution in v20.6.0 changelog (#50564) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch JakobJingleheimer:correct-20.6.0-changelog -> nodejs:main Labels fast-track, author ready, release, commit-queue-squash Commits 1 - doc: correct attribution in v20.6.0 changelog Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/50564 Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50564 Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 05 Nov 2023 15:23:59 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50564#pullrequestreview-1716407245 ℹ This PR is being fast-tracked ✘ This PR needs to wait 136 more hours to land (or 16 hours if there is one more approval) (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6777728206 |
ovflowd approved these changes Nov 7, 2023
JakobJingleheimer added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 7, 2023
Landed in c5e1fd0 |
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
PR-URL: nodejs#50564 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50564 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
targos pushed a commit that referenced this pull request Nov 14, 2023
PR-URL: #50564 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #50564 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what happened when these were generated, but the original PR that introduced the feature was omitted and co-authorship on both PRs was lost.
Related: nodejs/nodejs.org#6095