Skip to content

lib: remove deprecated string methods#50592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Nov 11, 2023
Merged

lib: remove deprecated string methods #50592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/_http_agent.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ const{
StringPrototypeIndexOf,
StringPrototypeSplit,
StringPrototypeStartsWith,
StringPrototypeSubstr,
StringPrototypeSubstring,
Symbol,
} = primordials;

Expand DownExpand Up@@ -363,7 +363,7 @@ function calculateServerName(options, req){
// Leading '[', but no ']'. Need to do something...
servername = hostHeader;
} else{
servername = StringPrototypeSubstr(hostHeader, 1, index - 1);
servername = StringPrototypeSubstring(hostHeader, 1, index);
}
} else{
servername = StringPrototypeSplit(hostHeader, ':', 1)[0];
Expand Down
4 changes: 2 additions & 2 deletions lib/internal/main/print_help.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@ const{
RegExpPrototypeSymbolReplace,
StringPrototypeLocaleCompare,
StringPrototypeSlice,
StringPrototypeTrimLeft,
StringPrototypeTrimStart,
StringPrototypeRepeat,
SafeMap,
} = primordials;
Expand DownExpand Up@@ -180,7 +180,7 @@ function format(
else
text += StringPrototypeRepeat(' ', firstColumn - displayName.length);

text += StringPrototypeTrimLeft(
text += StringPrototypeTrimStart(
indent(fold(displayHelpText, secondColumn), firstColumn)) + '\n'
}

Expand Down
4 changes: 2 additions & 2 deletions lib/repl.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -90,7 +90,7 @@ const{
StringPrototypeSplit,
StringPrototypeStartsWith,
StringPrototypeTrim,
StringPrototypeTrimLeft,
StringPrototypeTrimStart,
StringPrototypeToLocaleLowerCase,
Symbol,
SyntaxError,
Expand DownExpand Up@@ -1326,7 +1326,7 @@ function complete(line, callback){
let completeOn, group;

// Ignore right whitespace. It could change the outcome.
line = StringPrototypeTrimLeft(line);
line = StringPrototypeTrimStart(line);

let filter = ''

Expand Down