Skip to content

Replace forEach() with for .. of#50605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 11, 2023
Merged

Replace forEach() with for .. of #50605

nodejs-github-bot merged 1 commit into from
Nov 11, 2023

Conversation

@bliakher
Copy link
Contributor

@bliakherbliakher commented Nov 7, 2023

  • replace forEach() with for .. of loop in test-async-wrap-constructor.js

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@marco-ippolitomarco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2023•
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/55524/ 💛

@jasnelljasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2023
@nodejs-github-botnodejs-github-bot merged commit b8cfb35 into nodejs:mainNov 11, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 11, 2023

Landed in b8cfb35

targos pushed a commit that referenced this pull request Nov 11, 2023
@bliakher@targos
test: replace forEach() with for .. of
5184f1f
PR-URL: #50605 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@bliakher@targos
test: replace forEach() with for .. of
b701567
PR-URL: #50605 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@bliakher@UlisesGascon
test: replace forEach() with for .. of
7b9b1fb
PR-URL: #50605 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bliakher@nodejs-github-bot@jasnell@lpinca@marco-ippolito