test: use destructuring for accessing setting values#50609
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
yedlosh commented Nov 7, 2023
yedlosh commented - Use destructuring in line 107 of test-http2-session-settings.js
- Replaces index based access to the setting values
- (nodeconfeu workshop)
nodejs-github-bot added needs-ci 
marco-ippolito added the code-and-learn 
anonrig approved these changes Nov 7, 2023
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Nov 7, 2023
tniessen approved these changes Nov 7, 2023
This was referenced Nov 8, 2023
lpinca approved these changes Nov 10, 2023
Collaborator
27 tasks
jasnell reviewed Nov 11, 2023
| ['maxHeaderSize',-1], | ||
| ['maxHeaderSize',2**32], | ||
| ].forEach((i)=>{ | ||
| ].forEach(([key,value])=>{ |
Member
There was a problem hiding this comment.
This is fine but it would probably be worth changing this for a for (...) loop instead of forEach(...)
jasnell approved these changes Nov 11, 2023
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 11, 2023
Landed in 5c500b7 |
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50609 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
18 tasks
targos pushed a commit that referenced this pull request Nov 14, 2023
PR-URL: #50609 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #50609 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.