doc: add r2 cloudflare instruction on release#50623
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Nov 8, 2023
Review requested:
|
ovflowd added fast-track 
Fast-track has been requested by @ovflowd. Please 👍 to approve. |
ovflowdforce-pushed the doc-cloudflare-release-workflows branch from 0b03c59 to 189bef4Compare
MoLow commented Nov 8, 2023
What is the long term plan for making this automated? |
The idea is to create a workflow on |
tniessen left a comment
tniessen left a comment There was a problem hiding this comment.
Nit: commit message must be changed to adhere to the guidelines before merging.
Uh oh!
There was an error while loading. Please reload this page.
ovflowd changed the title 
ovflowd commented Nov 8, 2023
Done, afaik squashing will use the PR title, right? |
ovflowdforce-pushed the doc-cloudflare-release-workflows branch from 887757b to 85ea028Compare
Update doc/contributing/releases.md Co-authored-by: Tobias Nießen <[email protected]>
ovflowdforce-pushed the doc-cloudflare-release-workflows branch from 85ea028 to 1915c04Compare| For now, after a release is done, the symlinks need to be updated manually. | ||
| This can be done by simply | ||
| [triggering this GitHub Worfklow](https://github.com/nodejs/release-cloudflare-worker/actions/workflows/update-links.yml). |
There was a problem hiding this comment.
| [triggering this GitHub Worfklow](https://github.com/nodejs/release-cloudflare-worker/actions/workflows/update-links.yml). | |
| [triggering this GitHub Worfklow](https://github.com/nodejs/release-cloudflare-worker/actions/workflows/update-links.yml), and then [deploying](https://github.com/nodejs/release-cloudflare-worker/actions/workflows/deploy.yml) the update |
There was a problem hiding this comment.
Is the manual deployment really needed? Doesn't the sync already deploy it?
There was a problem hiding this comment.
we can add that to the sync workflow, but it currently only opens a PR
tniessen commented Nov 8, 2023
It does? That would be news to me, but might be! |
IIRC It does not node/tools/actions/commit-queue.sh Line 52 in fd4a305 |
targos commented Nov 13, 2023
Automation: #50710 |
Refs: #50623 PR-URL: #50710 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Refs: #50623 PR-URL: #50710 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Refs: nodejs#50623 PR-URL: nodejs#50710 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Refs: #50623 PR-URL: #50710 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Refs: #50623 PR-URL: #50710 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This PR simply updates the Release Documentation with a temporary instruction set for updating the symlinks on the Cloudflare R2 Workers.