Skip to content

Conversation

@kylo5aby
Copy link
Contributor

Compare to v18.x and 22.x, in the benchmark for util.inspect,
when obj is Date, as n increases,
the difference in benchmark results gradually grows larger,
possibly also due to the influence of V8 JIT.

n = [2e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=20000 *** -21.01 % ±1.95% ±2.60% ±3.39% util/inspect.js option='none' method='Date' n=20000 *** -24.24 % ±1.64% ±2.19% ±2.86% util/inspect.js option='showHidden' method='Date' n=20000 *** -21.55 % ±1.32% ±1.76% ±2.30% n = [4e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=40000 *** -25.63 % ±1.88% ±2.50% ±3.26% util/inspect.js option='none' method='Date' n=40000 *** -29.94 % ±1.20% ±1.60% ±2.09% util/inspect.js option='showHidden' method='Date' n=40000 *** -23.07 % ±2.99% ±4.01% ±5.30% n = [6e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=60000 *** -28.01 % ±1.49% ±1.99% ±2.61% util/inspect.js option='none' method='Date' n=60000 *** -32.91 % ±1.53% ±2.05% ±2.71% util/inspect.js option='showHidden' method='Date' n=60000 *** -27.59 % ±2.30% ±3.07% ±4.01% n = [8e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=80000 *** -31.34 % ±1.55% ±2.07% ±2.70% util/inspect.js option='none' method='Date' n=80000 *** -32.49 % ±1.48% ±1.98% ±2.59% util/inspect.js option='showHidden' method='Date' n=80000 *** -28.80 % ±1.76% ±2.34% ±3.05% n = [1e5]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=100000 *** -30.87 % ±2.19% ±2.92% ±3.80% util/inspect.js option='none' method='Date' n=100000 *** -33.26 % ±1.79% ±2.39% ±3.12% util/inspect.js option='showHidden' method='Date' n=100000 *** -28.31 % ±2.07% ±2.75% ±3.58% n = [12e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=120000 *** -31.74 % ±1.84% ±2.45% ±3.21% util/inspect.js option='none' method='Date' n=120000 *** -32.62 % ±1.30% ±1.73% ±2.26% util/inspect.js option='showHidden' method='Date' n=120000 *** -30.19 % ±1.89% ±2.51% ±3.27% n = [14e4]: confidence improvement accuracy (*) (**) (***) util/inspect.js option='colors' method='Date' n=140000 *** -29.44 % ±1.78% ±2.37% ±3.08% util/inspect.js option='none' method='Date' n=140000 *** -34.54 % ±1.45% ±1.94% ±2.57% util/inspect.js option='showHidden' method='Date' n=140000 *** -29.27 % ±2.12% ±2.83% ±3.68%

Refs: #50571

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Nov 10, 2023
@H4adH4ad added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 17, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95aduh95 merged commit cdb6519 into nodejs:mainNov 29, 2023
@aduh95
Copy link
Contributor

Landed in cdb6519

targos pushed a commit that referenced this pull request Dec 4, 2023
PR-URL: #50651 Refs: #50571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@targostargos mentioned this pull request Dec 4, 2023
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #50651 Refs: #50571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.utilIssues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kylo5aby@nodejs-github-bot@aduh95@jasnell@H4ad