Skip to content

deps: V8: cherry-pick 8f0b94671ddb#50654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 12, 2023
Merged

deps: V8: cherry-pick 8f0b94671ddb #50654

nodejs-github-bot merged 1 commit into from
Nov 12, 2023

Conversation

@luyahan
Copy link
Contributor

@luyahanluyahan commented Nov 10, 2023

Original commit message:

[gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347}

Refs: v8/v8@8f0b946

@luyahan
deps: V8: cherry-pick 8f0b94671ddb
ccdf997
Original commit message: [gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347} Refs: v8/v8@8f0b946
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2023

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@luyahan
Copy link
ContributorAuthor

luyahan commented Nov 10, 2023

fix debug build failed

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Nov 10, 2023
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55534/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5656/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5656/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5656/

@github-actionsgithub-actionsbot mentioned this pull request Nov 11, 2023
Open
27 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 11, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55567/

@github-actionsgithub-actionsbot mentioned this pull request Nov 12, 2023
Open
18 tasks
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2023
@nodejs-github-botnodejs-github-bot merged commit 0ee49c8 into nodejs:mainNov 12, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2023

Landed in 0ee49c8

@targostargos added dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Nov 12, 2023
This was referenced Nov 13, 2023
Open
Open
targos pushed a commit that referenced this pull request Nov 23, 2023
@luyahan@targos
deps: V8: cherry-pick 8f0b94671ddb
3731f83
Original commit message: [gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347} Refs: v8/v8@8f0b946 PR-URL: #50654 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
targos pushed a commit to targos/node that referenced this pull request Dec 18, 2023
@luyahan@targos
deps: V8: cherry-pick 8f0b94671ddb
34715c4
Original commit message: [gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347} Refs: v8/v8@8f0b946 PR-URL: nodejs#50654 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 18, 2023
@luyahan@targos
deps: V8: cherry-pick 8f0b94671ddb
6facba6
Original commit message: [gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347} Refs: v8/v8@8f0b946 PR-URL: nodejs#50654 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 21, 2023
@luyahan@targos
deps: V8: cherry-pick 8f0b94671ddb
9a0b2f5
Original commit message: [gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347} Refs: v8/v8@8f0b946 PR-URL: nodejs#50654 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 21, 2023
@luyahan@targos
deps: V8: cherry-pick 8f0b94671ddb
ef71b30
Original commit message: [gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347} Refs: v8/v8@8f0b946 PR-URL: nodejs#50654 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 22, 2023
@luyahan@targos
deps: V8: cherry-pick 8f0b94671ddb
fe71d38
Original commit message: [gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347} Refs: v8/v8@8f0b946 PR-URL: nodejs#50654 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 22, 2023
@luyahan@targos
deps: V8: cherry-pick 8f0b94671ddb
0eea8ee
Original commit message: [gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347} Refs: v8/v8@8f0b946 PR-URL: nodejs#50654 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 4, 2024
@luyahan@targos
deps: V8: cherry-pick 8f0b94671ddb
782addb
Original commit message: [gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347} Refs: v8/v8@8f0b946 PR-URL: #50654 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #50115 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@luyahan@Medhansh404
deps: V8: cherry-pick 8f0b94671ddb
236f18a
Original commit message: [gcc] Add include for TurboShaft Include <limits> for std::numeric_limits. Bug: chromium:819294 Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#90347} Refs: v8/v8@8f0b946 PR-URL: nodejs#50654 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: nodejs#50115 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.dont-land-on-v20.xPRs that should not land on the v20.x-staging branch and should not be released in v20.x.needs-ciPRs that need a full CI run.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@luyahan@nodejs-github-bot@jasnell@richardlau@lpinca@targos