Skip to content

stream: WPT fixes for Compression Streams#50712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
panva wants to merge 3 commits into from
Closed

stream: WPT fixes for Compression Streams #50712

panva wants to merge 3 commits into from

Conversation

@panva
Copy link
Member

@panvapanva commented Nov 13, 2023•
edited
Loading

Followup to #50631

  • adds the expected Symbol.toStringTag to CompressionStream and DecompressionStream
  • yields the expected error (TypeError) on corrupt inputs
  • updates the idlharness test files and expectations overall

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 13, 2023

Review requested:

  • @nodejs/web-standards

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Nov 13, 2023
@panva
Copy link
MemberAuthor

panva commented Nov 13, 2023

cc @nodejs/streams

@panvapanva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Nov 13, 2023
@panvapanvaforce-pushed the wpt-compression-fixes branch from eaf6907 to 00a38f5CompareNovember 13, 2023 14:23
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig reviewed Nov 13, 2023
View reviewed changes
ljharb
ljharb reviewed Nov 13, 2023
View reviewed changes
@github-actionsgithub-actionsbot mentioned this pull request Nov 14, 2023
Open
25 tasks
@panvapanvaforce-pushed the wpt-compression-fixes branch from f13ccd6 to 100f25cCompareNovember 14, 2023 08:45
@panvapanvaforce-pushed the wpt-compression-fixes branch from 100f25c to 74d8ee5CompareNovember 14, 2023 08:50
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 14, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55645/

@github-actionsgithub-actionsbot mentioned this pull request Nov 15, 2023
Open
26 tasks
@panvapanva requested review from anonrig and ljharbNovember 18, 2023 12:25
@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2023
mcollina
mcollina approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2023
nodejs-github-bot pushed a commit that referenced this pull request Nov 19, 2023
@panva@nodejs-github-bot
test: update WPT files for WebIDL tests
e0bbe8f
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@panvapanva deleted the wpt-compression-fixes branch November 19, 2023 07:37
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva@targos
stream: add Symbol.toStringTag to Compression Streams
af9cd35
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva@targos
stream: yield expected Error class on zlib errors
1f9065d
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva@targos
test: update WPT files for WebIDL tests
b6c3cef
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@panva@martenrichter
stream: add Symbol.toStringTag to Compression Streams
15c5b31
PR-URL: nodejs#50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@panva@martenrichter
stream: yield expected Error class on zlib errors
8a2bc14
PR-URL: nodejs#50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@panva@martenrichter
test: update WPT files for WebIDL tests
4154929
PR-URL: nodejs#50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@panva
stream: add Symbol.toStringTag to Compression Streams
426ca12
PR-URL: nodejs#50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@panva
stream: yield expected Error class on zlib errors
d899d5e
PR-URL: nodejs#50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@panva
test: update WPT files for WebIDL tests
cbdf5a6
PR-URL: nodejs#50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@panva@RafaelGSS
stream: add Symbol.toStringTag to Compression Streams
a275155
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@panva@RafaelGSS
stream: yield expected Error class on zlib errors
2e0abed
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@panva@RafaelGSS
test: update WPT files for WebIDL tests
f25637b
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@panva@RafaelGSS
stream: add Symbol.toStringTag to Compression Streams
6aa1f26
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@panva@RafaelGSS
stream: yield expected Error class on zlib errors
1aa5a48
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@panva@RafaelGSS
test: update WPT files for WebIDL tests
1b5842d
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
8b1ff5a
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 12, 2023
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
c519e80
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
1aec6f6
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
21c61f5
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@panvapanva added backport-blocked-v18.x backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. labels Dec 15, 2023
@panva
Copy link
MemberAuthor

panva commented Dec 15, 2023•
edited
Loading

Backport blocked until #50097 is also backported.

UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
23734d5
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Jan 9, 2024
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
4cf155c
PR-URL: #50712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@targostargos added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. and removed backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. labels Sep 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@anonriganonriganonrig approved these changes

@ljharbljharbAwaiting requested review from ljharb

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.dont-land-on-v20.xPRs that should not land on the v20.x-staging branch and should not be released in v20.x.needs-ciPRs that need a full CI run.web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@panva@nodejs-github-bot@ljharb@mcollina@anonrig@targos