test: give more time to GC in test-shadow-realm-gc-*#50735
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
joyeecheung commented Nov 14, 2023
Uh oh!
There was an error while loading. Please reload this page.
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Nov 14, 2023
26 tasks
targos reviewed Nov 15, 2023
Uh oh!
There was an error while loading. Please reload this page.
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop.
joyeecheungforce-pushed the shadow-realm-gc branch from 59eac85 to f2a9e57Comparegithub-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 15, 2023
legendecas approved these changes Nov 15, 2023
MemberAuthor
Testing with EDIT: er...looks like |
MemberAuthor
Stress test for affected platforms (using nodejs/reliability#718) https://ci.nodejs.org/job/node-stress-single-test/465/ |
Collaborator
nodejs-github-bot commented Nov 16, 2023
MemberAuthor
I am again seeing this in the V8 integration CI, not sure if this fixes the flake over there https://logs.chromium.org/logs/node-ci/buildbucket/cr-buildbucket/8764249834281259873/+/u/test_default__retry_/stdout |
MemberAuthor
Last CI and stress tests were green although the bot did not communicate the result to GitHub again (failures are from #50735 (comment) which wasn't supported by the CI..) |
joyeecheung changed the title MemberAuthor
This needs another LGTM to land - I am seeing this again in another V8 CI so it's better to deflake them sooner too. |
anonrig approved these changes Nov 17, 2023
joyeecheung added a commit that referenced this pull request Nov 17, 2023
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: #50735 Refs: #50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
MemberAuthor
joyeecheung commented Nov 17, 2023
landed in c5eb2c4 |
pthier pushed a commit to v8/node that referenced this pull request Nov 20, 2023
Partial cherry-pick of nodejs#50735
targos pushed a commit that referenced this pull request Nov 23, 2023
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: #50735 Refs: #50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: nodejs#50735 Refs: nodejs#50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
zcbenz pushed a commit to photoionization/node_ci that referenced this pull request Nov 27, 2023
To include (partially) nodejs/node#50735 to fix flaky tests. Change-Id: I5355397d639bcb03ca2f5de24200db18d6e02505 Reviewed-on: https://chromium-review.googlesource.com/c/v8/node-ci/+/5038521 Reviewed-by: Victor Gomes <[email protected]> Auto-Submit: Patrick Thier <[email protected]> Commit-Queue: Victor Gomes <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: nodejs#50735 Refs: nodejs#50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: #50735 Refs: #50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: #50735 Refs: #50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: #50735 Refs: #50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test.
As a workaround, give GC a bit more time by waiting for a timer in the loop.
Refs: #50726