Skip to content

fs: fix to not return for void function#50769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 24, 2023
Merged

fs: fix to not return for void function #50769

nodejs-github-bot merged 1 commit into from
Nov 24, 2023

Conversation

@pluris
Copy link
Contributor

@plurispluris commented Nov 17, 2023

APIs with return type defined as void in jsdoc and document have been modified to not return a value.

@nodejs-github-botnodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 17, 2023
@anonrig
Copy link
Member

anonrig commented Nov 17, 2023

Can you make sure your commit follows the recommended commit guidelines?

@plurispluris changed the title fs: fixed to not return for void functionfs: fix to not return for void functionNov 17, 2023
@pluris
Copy link
ContributorAuthor

pluris commented Nov 17, 2023

@anonrig I made a mistake. Thank you I fixed it.

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 17, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55718/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55807/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-botnodejs-github-bot merged commit ec79232 into nodejs:mainNov 24, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 24, 2023

Landed in ec79232

martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@martenrichter
fs: fix to not return for void function
964eb69
PR-URL: nodejs#50769 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
fs: fix to not return for void function
5b17fc9
PR-URL: nodejs#50769 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@RafaelGSS
fs: fix to not return for void function
c09be09
PR-URL: #50769 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@RafaelGSS
fs: fix to not return for void function
45b2bb0
PR-URL: #50769 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@RafaelGSS
fs: fix to not return for void function
e65bde8
PR-URL: #50769 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@UlisesGascon
fs: fix to not return for void function
c9761df
PR-URL: #50769 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@UlisesGascon
fs: fix to not return for void function
986183b
PR-URL: #50769 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@UlisesGascon
fs: fix to not return for void function
55b8e48
PR-URL: #50769 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@UlisesGascon
fs: fix to not return for void function
cada22e
PR-URL: #50769 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@anonriganonriganonrig approved these changes

@Ayase-252Ayase-252Ayase-252 approved these changes

@KhafraDevKhafraDevKhafraDev approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pluris@anonrig@nodejs-github-bot@jasnell@lpinca@Ayase-252@KhafraDev