Skip to content

test: replace forEach with for of in test-trace-events-api.js#50784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andp97 wants to merge 1 commit into from
Closed

test: replace forEach with for of in test-trace-events-api.js #50784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions test/parallel/test-trace-events-api.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ const isChild = process.argv[2] === 'child'
constenabledCategories=getEnabledCategoriesFromCommandLine();

assert.strictEqual(getEnabledCategories(),enabledCategories);
[1,'foo',true,false,null,undefined].forEach((i)=>{
for(constiof[1,'foo',true,false,null,undefined]){
assert.throws(()=>createTracing(i),{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError'
Expand All@@ -40,7 +40,7 @@ assert.strictEqual(getEnabledCategories(), enabledCategories);
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError'
});
});
}

assert.throws(
()=>createTracing({categories: []}),
Expand DownExpand Up@@ -156,8 +156,7 @@ function testApiInChildProcess(execArgs, cb){
assert.strictEqual(
traces.length,
expectedBegins.length+expectedEnds.length);

traces.forEach((trace)=>{
for(consttraceoftraces){
assert.strictEqual(trace.pid,proc.pid);
switch(trace.ph){
case'b': {
Expand All@@ -175,7 +174,7 @@ function testApiInChildProcess(execArgs, cb){
default:
assert.fail('Unexpected trace event phase');
}
});
}
process.chdir(parentDir);
cb&&process.nextTick(cb);
}));
Expand Down