dns: call handle.setServers() with a valid array#50811
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`handle.setServers()` takes an array, not a string.
Collaborator
nodejs-github-bot commented Nov 19, 2023
Review requested:
|
nodejs-github-bot added dns 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 19, 2023
jasnell approved these changes Nov 19, 2023
marco-ippolito approved these changes Nov 21, 2023
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 21, 2023
Landed in 053f368 |
targos pushed a commit that referenced this pull request Nov 23, 2023
`handle.setServers()` takes an array, not a string. PR-URL: #50811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
`handle.setServers()` takes an array, not a string. PR-URL: nodejs#50811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
`handle.setServers()` takes an array, not a string. PR-URL: nodejs#50811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
`handle.setServers()` takes an array, not a string. PR-URL: #50811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
`handle.setServers()` takes an array, not a string. PR-URL: #50811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
`handle.setServers()` takes an array, not a string. PR-URL: #50811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
`handle.setServers()` takes an array, not a string. PR-URL: #50811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
`handle.setServers()` takes an array, not a string. PR-URL: #50811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle.setServers()takes an array, not a string.