Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Feb 4, 2016

A few tests have started failing on Raspberry Pi devices in CI.
https://ci.nodejs.org/job/node-test-binary-arm/943/

Ref: #4830
Ref: #3635
Ref: #4526

@TrottTrott added test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. labels Feb 4, 2016
@cjihrig
Copy link
Contributor

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indentation here if you're trying to align the colons?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, mixture of spaces and tabs, will fix.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixed, squashed, and force-pushed. Thanks.

A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ Ref: nodejs#4830 Ref: nodejs#3635 Ref: nodejs#4526
@TrottTrottforce-pushed the raspberry-pi-flakies branch from a6ca473 to 8c03422CompareFebruary 4, 2016 21:09
@r-52
Copy link
Contributor

r-52 commented Feb 4, 2016

LGTM

@Trott
Copy link
MemberAuthor

Trott commented Feb 5, 2016

@Trott
Copy link
MemberAuthor

Trott commented Feb 6, 2016

Landed in 6e3bccb

@TrottTrott closed this Feb 6, 2016
Trott added a commit that referenced this pull request Feb 6, 2016
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
rvagg pushed a commit that referenced this pull request Feb 8, 2016
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
rvagg pushed a commit that referenced this pull request Feb 9, 2016
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
@MylesBorinsMylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: #4830 Ref: #3635 Ref: #4526
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: nodejs#5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: nodejs#4830 Ref: nodejs#3635 Ref: nodejs#4526
@TrottTrott deleted the raspberry-pi-flakies branch January 13, 2022 22:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

armIssues and PRs related to the ARM platform.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@cjihrig@r-52@mscdex@MylesBorins