doc: make theme consistent across api and other docs (from nodejs.org repo)

[demakoff]

Problem: since the website is based on 2 different repos (this and nodejs.org), there was an inconsistency in theme selection, so we had 2 independent theme props (one in session storage and another in local storage). With these changes, only one stored in local storage (theme: light | dark) is a single source of truth across all pages.

Before:

After:

[nodejs-github-bot]

Review requested:

• @nodejs/nodejs-website
• @nodejs/tsc

[ovflowd]

The change looks good to me. Keep in mind we're eventually going to redesign the API Docs together with the Node.js Website.

[ovflowd]

@demakoff please run make format-md

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/50877 ✔ Done loading data for nodejs/node/pull/50877 ----------------------------------- PR info ------------------------------------ Title doc: make theme consistent across api and other docs (from nodejs.org repo) (#50877) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch demakoff:align-themes -> nodejs:main Labels doc, build Commits 3 - doc: make theme consistent across api and other docs - doc: update formatting - Update md formatting Committers 1 - Dima Demakov PR-URL: https://github.com/nodejs/node/pull/50877 Reviewed-By: Claudio Wunder Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50877 Reviewed-By: Claudio Wunder Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 23 Nov 2023 12:01:04 GMT ✔ Approvals: 2 ✔ - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/50877#pullrequestreview-1749420896 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50877#pullrequestreview-1748014170 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50877 From https://github.com/nodejs/node * branch refs/pull/50877/merge -> FETCH_HEAD ✔ Fetched commits as 4466deeb3432..56045316fd35 -------------------------------------------------------------------------------- [main e3efa97947] doc: make theme consistent across api and other docs Author: Dima Demakov Date: Fri Nov 24 14:33:24 2023 +0100 3 files changed, 15 insertions(+), 8 deletions(-) [main 1a53995fdb] doc: update formatting Author: Dima Demakov Date: Fri Nov 24 16:52:00 2023 +0100 1 file changed, 1 insertion(+), 2 deletions(-) [main e27f783a13] Update md formatting Author: Dima Demakov Date: Sun Nov 26 18:01:56 2023 +0100 1 file changed, 4 insertions(+), 3 deletions(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6) 
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 doc: make theme consistent across api and other docs
Since website based on 2 different repos, there was an inconsistency
 in theme selection, so we had 2 independant theme props.
 Now only one stored in local storage is a single source of truth
PR-URL: #50877
 Reviewed-By: Claudio Wunder [email protected]
 Reviewed-By: Yagiz Nizipli [email protected]
[detached HEAD 5fd00cecbb] doc: make theme consistent across api and other docs
 Author: Dima Demakov [email protected]
 Date: Fri Nov 24 14:33:24 2023 +0100
 3 files changed, 15 insertions(+), 8 deletions(-)
 Rebasing (3/6)
 Rebasing (4/6)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 doc: update formatting
PR-URL: #50877
 Reviewed-By: Claudio Wunder [email protected]
 Reviewed-By: Yagiz Nizipli [email protected]
[detached HEAD 0de5adbd5f] doc: update formatting
 Author: Dima Demakov [email protected]
 Date: Fri Nov 24 16:52:00 2023 +0100
 1 file changed, 1 insertion(+), 2 deletions(-)
 Rebasing (5/6)
 Rebasing (6/6)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 Update md formatting
PR-URL: #50877
 Reviewed-By: Claudio Wunder [email protected]
 Reviewed-By: Yagiz Nizipli [email protected]
[detached HEAD 4d1a613278] Update md formatting
 Author: Dima Demakov [email protected]
 Date: Sun Nov 26 18:01:56 2023 +0100
 1 file changed, 4 insertions(+), 3 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6998992998

[ovflowd]

@demakoff I think we need an email (even if an anonymous one) to be listed on your GitHub profile

[demakoff]

@demakoff I think we need an email (even if an anonymous one) to be listed on your GitHub profile

Super weird TBH. I have a few specified, incl the primary one which is configured in git to use on commit 🤔
Ok, I've specified that primary as public, hope it will help. Can we try to add in to the queue once again plz @ovflowd

[nodejs-github-bot]

Landed in 62fc950