url: revokeObjectURL should throw an error when no parameter is provided#50925
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 26, 2023
Review requested:
|
nodejs-github-bot added needs-ci 
himself65 requested changes Nov 26, 2023
Member
himself65 left a comment
himself65 left a comment There was a problem hiding this comment.
This looks good since it fits with the web API. But You might need to add a test case
Member
There was a problem hiding this comment.
This file is not supposed to have. Please remove it
Author
There was a problem hiding this comment.
How do I add a test case? I also see an error which says the following:
Check failure on line 1107 in lib/internal/url.js
GitHub Actions
/ lint-js-and-md
Expected '===' and instead saw '=='
am I to fix this as well or?
himself65 changed the title revokeObjectURL should throw an error when no parameter is provided
Contributor
meyfa commented Nov 26, 2023
This fixes issue #50432, which could be added to the PR description. |
Contributor
deokjinkim commented Nov 28, 2023
Duplicate of#50433 |
marco-ippolito added the duplicate Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I failed to follow the guidelines for my first commit. I made a typo error so I can reproduce the code and submit it with the correct guidelines. Thank you !