Skip to content

benchmark: update iterations in benchmark/util/inspect-array.js#50933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 4, 2023
Merged

benchmark: update iterations in benchmark/util/inspect-array.js #50933

nodejs-github-bot merged 1 commit into from
Dec 4, 2023

Conversation

@lucshi
Copy link

@lucshilucshi commented Nov 27, 2023•
edited by H4ad
Loading

Refs: #50571

Belowing are the score improvement after 10X iteration change:

util/inspect-array.js n=5000 util/inspect-array.js type="denseArray" n=5000 percent=159.84% util/inspect-array.js type="sparseArray" n=5000 percent=245.72% util/inspect-array.js type="denseArray_showHidden" n=5000 percent=158.26% util/inspect-array.js type="denseArray" n=5000 percent=164.69% util/inspect-array.js type="denseArray_showHidden" n=5000 percent=158.53%

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Nov 27, 2023
H4ad
H4ad approved these changes Dec 2, 2023
View reviewed changes
@H4adH4ad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2023
@H4adH4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2023
@nodejs-github-botnodejs-github-bot merged commit 964046d into nodejs:mainDec 4, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 4, 2023

Landed in 964046d

@H4ad
Copy link
Member

H4ad commented Dec 4, 2023

@UlisesGascon do you know why your email was not included in the commit as reviewer?

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@RafaelGSS
benchmark: update iterations in benchmark/util/inspect-array.js
dbee03d
Fixes: #50571 PR-URL: #50933 Refs: #50571 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@richardlau
benchmark: update iterations in benchmark/util/inspect-array.js
4fc83e1
Fixes: #50571 PR-URL: #50933 Refs: #50571 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGasconUlisesGasconUlisesGascon approved these changes

@H4adH4adH4ad approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucshi@nodejs-github-bot@H4ad@UlisesGascon