Skip to content

Conversation

@lucshi
Copy link

@lucshilucshi commented Nov 27, 2023

Refs: #50571

Belowing are the score improvement after 10X iteration change:

util/type-check.js n=1000000 util/type-check.js argument="true" type="ArrayBufferView": n=1000000 percent=758.19% util/type-check.js argument="false-primitive" type="ArrayBufferView": n=1000000 percent=745.55% util/type-check.js argument="false-object" type="ArrayBufferView": n=1000000 percent=760.94% util/type-check.js argument="true" type="ArrayBufferView": n=1000000 percent=793.30% util/type-check.js argument="false-primitive" type="ArrayBufferView": n=1000000 percent=772.28% util/type-check.js argument="false-object" type="ArrayBufferView": n=1000000 percent=791.04% util/type-check.js argument="true" type="TypedArray": n=1000000 percent=568.78% util/type-check.js argument="false-primitive" type="TypedArray": n=1000000 percent=644.47% util/type-check.js argument="false-object" type="TypedArray": n=1000000 percent=599.05% util/type-check.js argument="true" type="TypedArray": n=1000000 percent=587.63% util/type-check.js argument="false-primitive" type="TypedArray": n=1000000 percent=623.71% util/type-check.js argument="false-object" type="TypedArray": n=1000000 percent=624.70% util/type-check.js argument="true" type="Uint8Array": n=1000000 percent=565.48% util/type-check.js argument="false-primitive" type="Uint8Array": n=1000000 percent=592.64% util/type-check.js argument="false-object" type="Uint8Array": n=1000000 percent=570.08% util/type-check.js argument="true" type="Uint8Array": n=1000000 percent=588.70% util/type-check.js argument="false-primitive" type="Uint8Array": n=1000000 percent=611.18% util/type-check.js argument="false-object" type="Uint8Array": n=1000000 percent=588.04% 

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Nov 27, 2023
H4ad
H4ad approved these changes Dec 2, 2023
@H4adH4ad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2023
@H4adH4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2023
@nodejs-github-botnodejs-github-bot merged commit 36a75e8 into nodejs:mainDec 4, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 36a75e8

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
Fixes: #50571 PR-URL: #50937 Refs: #50571 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Dec 15, 2023
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Fixes: #50571 PR-URL: #50937 Refs: #50571 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.utilIssues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lucshi@nodejs-github-bot@UlisesGascon@H4ad