test: resolve flakiness in worker*.test-free-called#51013
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added addons 
MrJithilforce-pushed the fix-51003-test-free-called-is-flaky branch 4 times, most recently from 164741e to c306d18Compare
H4ad approved these changes Dec 2, 2023
MrJithil added the author ready 
joyeecheung approved these changes Dec 7, 2023
Member
joyeecheung left a comment
joyeecheung left a comment There was a problem hiding this comment.
I think the right subsystem should be “test:”
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Dec 7, 2023
Collaborator
nodejs-github-bot commented Dec 7, 2023
lpinca approved these changes Dec 7, 2023
H4ad added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Dec 7, 2023
Commit Queue failed- Loading data for nodejs/node/pull/51013 ✔ Done loading data for nodejs/node/pull/51013 ----------------------------------- PR info ------------------------------------ Title fix: resolve flakiness in worker*.test-free-called (#51013) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MrJithil:fix-51003-test-free-called-is-flaky -> nodejs:main Labels test, addons, author ready, needs-ci Commits 1 - test: fix flakiness in worker*.test-free-called Committers 1 - Jithil P Ponnan PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 02 Dec 2023 05:44:01 GMT ✔ Approvals: 3 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51013#pullrequestreview-1760948847 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1769070609 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51013#pullrequestreview-1770962147 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-12-07T11:14:40Z: https://ci.nodejs.org/job/node-test-pull-request/56149/ - Querying data for job/node-test-pull-request/56149/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51013 From https://github.com/nodejs/node * branch refs/pull/51013/merge -> FETCH_HEAD ✔ Fetched commits as 42b238ec9ac2..c306d1832849 -------------------------------------------------------------------------------- [main 8b345bdba2] test: fix flakiness in worker*.test-free-called Author: Jithil P Ponnan Date: Sat Dec 2 13:36:19 2023 +0800 1 file changed, 3 insertions(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- ✘ Git found no trailers in the original commit message, but 'Fixes: https://github.com/nodejs/node/issues/51003' is present and should be a trailer.https://github.com/nodejs/node/actions/runs/7134450198 |
MrJithil added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Dec 9, 2023
Commit Queue failed- Loading data for nodejs/node/pull/51013 ✔ Done loading data for nodejs/node/pull/51013 ----------------------------------- PR info ------------------------------------ Title fix: resolve flakiness in worker*.test-free-called (#51013) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MrJithil:fix-51003-test-free-called-is-flaky -> nodejs:main Labels test, addons, author ready, needs-ci Commits 1 - test: fix flakiness in worker*.test-free-called Committers 1 - Jithil P Ponnan PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 02 Dec 2023 05:44:01 GMT ✔ Approvals: 3 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51013#pullrequestreview-1760948847 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1769070609 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51013#pullrequestreview-1770962147 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-12-07T21:57:04Z: https://ci.nodejs.org/job/node-test-pull-request/56149/ - Querying data for job/node-test-pull-request/56149/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51013 From https://github.com/nodejs/node * branch refs/pull/51013/merge -> FETCH_HEAD ✔ Fetched commits as 1ba508d51b30..c306d1832849 -------------------------------------------------------------------------------- [main 311f4b7b68] test: fix flakiness in worker*.test-free-called Author: Jithil P Ponnan Date: Sat Dec 2 13:36:19 2023 +0800 1 file changed, 3 insertions(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- ✘ Git found no trailers in the original commit message, but 'Fixes: https://github.com/nodejs/node/issues/51003' is present and should be a trailer.https://github.com/nodejs/node/actions/runs/7148604463 |
nodejs-github-bot added the commit-queue-failed 
The issue arises from the `getFreeCallCount()` function yielding the initial value of 0. Upon instantiation of the `Worker` object, it increments to 1. In the case of this flaky test, if the creation of the `Worker` object is faster, the subsequent `getFreeCallCount()` call always returns 1 instead of the expected 0. Fixes: nodejs#51003
MrJithilforce-pushed the fix-51003-test-free-called-is-flaky branch from c306d18 to 2bf498cCompareMrJithil changed the title 
jasnell approved these changes Dec 9, 2023
MrJithil added commit-queue H4ad approved these changes Dec 9, 2023
nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Dec 9, 2023
Commit Queue failed- Loading data for nodejs/node/pull/51013 ✔ Done loading data for nodejs/node/pull/51013 ----------------------------------- PR info ------------------------------------ Title test: resolve flakiness in worker*.test-free-called (#51013) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MrJithil:fix-51003-test-free-called-is-flaky -> nodejs:main Labels test, addons, author ready, needs-ci Commits 1 - test: fix flakiness in worker*.test-free-called Committers 1 - Jithil P Ponnan PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51013 Fixes: https://github.com/nodejs/node/issues/51003 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 02 Dec 2023 05:44:01 GMT ✔ Approvals: 4 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51013#pullrequestreview-1773785072 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1769070609 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51013#pullrequestreview-1770962147 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51013#pullrequestreview-1773716931 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-12-09T02:57:36Z: https://ci.nodejs.org/job/node-test-pull-request/56149/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - test: fix flakiness in worker*.test-free-called - Querying data for job/node-test-pull-request/56149/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7152874215 |
github-actionsbot removed the request-ci This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Collaborator
nodejs-github-bot commented Dec 13, 2023
Collaborator
nodejs-github-bot commented Dec 13, 2023
debadree25 removed the commit-queue-failed 
UlisesGascon approved these changes Dec 13, 2023
Collaborator
nodejs-github-bot commented Dec 15, 2023
H4ad added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Dec 19, 2023
Landed in 64f7d0e |
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
The issue arises from the `getFreeCallCount()` function yielding the initial value of 0. Upon instantiation of the `Worker` object, it increments to 1. In the case of this flaky test, if the creation of the `Worker` object is faster, the subsequent `getFreeCallCount()` call always returns 1 instead of the expected 0. Fixes: #51003 PR-URL: #51013 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
The issue arises from the `getFreeCallCount()` function yielding the initial value of 0. Upon instantiation of the `Worker` object, it increments to 1. In the case of this flaky test, if the creation of the `Worker` object is faster, the subsequent `getFreeCallCount()` call always returns 1 instead of the expected 0. Fixes: #51003 PR-URL: #51013 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51003
The issue arises from the
getFreeCallCount()function yielding the initial value of 0. Upon instantiation of theWorkerobject, it increments to 1. In the case of this flaky test, if the creation of theWorkerobject is faster, the subsequentgetFreeCallCount()call always returns 1 instead of the expected 0.