Skip to content

crypto: use new.target instead of instaceof to detect construct calls#51026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 3 commits into from
Dec 5, 2023
Merged

crypto: use new.target instead of instaceof to detect construct calls #51026

nodejs-github-bot merged 3 commits into from
Dec 5, 2023
+23 −1

Conversation

@joyeecheung
Copy link
Member

@joyeecheungjoyeecheung commented Dec 3, 2023•
edited
Loading

The former is much more performant.

Refs: nodejs/performance#136

On macOS + M2:

 confidence improvement accuracy (*) (**) (***) crypto/webcrypto-digest.js n=100000 method='SHA-1' data=10 sync='createHash' *** 4.19 % ±1.05% ±1.40% ±1.84% crypto/webcrypto-digest.js n=100000 method='SHA-1' data=100 sync='createHash' *** 4.83 % ±0.64% ±0.85% ±1.10% crypto/webcrypto-digest.js n=100000 method='SHA-1' data=20 sync='createHash' ** 3.77 % ±2.59% ±3.49% ±4.62% crypto/webcrypto-digest.js n=100000 method='SHA-1' data=50 sync='createHash' *** 5.10 % ±0.56% ±0.75% ±0.98% crypto/webcrypto-digest.js n=100000 method='SHA-256' data=10 sync='createHash' *** 5.82 % ±2.27% ±3.05% ±4.04% crypto/webcrypto-digest.js n=100000 method='SHA-256' data=100 sync='createHash' *** 5.86 % ±2.46% ±3.31% ±4.37% crypto/webcrypto-digest.js n=100000 method='SHA-256' data=20 sync='createHash' *** 5.92 % ±2.24% ±3.02% ±4.00% crypto/webcrypto-digest.js n=100000 method='SHA-256' data=50 sync='createHash' *** 5.67 % ±0.50% ±0.66% ±0.87% crypto/webcrypto-digest.js n=100000 method='SHA-384' data=10 sync='createHash' *** 4.68 % ±0.72% ±0.96% ±1.25% crypto/webcrypto-digest.js n=100000 method='SHA-384' data=100 sync='createHash' *** 5.83 % ±2.52% ±3.39% ±4.49% crypto/webcrypto-digest.js n=100000 method='SHA-384' data=20 sync='createHash' * 2.91 % ±2.73% ±3.68% ±4.88% crypto/webcrypto-digest.js n=100000 method='SHA-384' data=50 sync='createHash' *** 4.19 % ±0.79% ±1.06% ±1.39% crypto/webcrypto-digest.js n=100000 method='SHA-512' data=10 sync='createHash' ** 3.51 % ±2.28% ±3.07% ±4.06% crypto/webcrypto-digest.js n=100000 method='SHA-512' data=100 sync='createHash' *** 5.01 % ±0.54% ±0.71% ±0.93% crypto/webcrypto-digest.js n=100000 method='SHA-512' data=20 sync='createHash' ** 4.38 % ±2.64% ±3.53% ±4.64% crypto/webcrypto-digest.js n=100000 method='SHA-512' data=50 sync='createHash' ** 4.01 % ±2.40% ±3.22% ±4.26% 
crypto/create-hash.js n=100000 *** 6.77 % ±3.00% ±3.99% ±5.20%

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2023

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Dec 3, 2023
@joyeecheungjoyeecheung mentioned this pull request Dec 3, 2023
Closed
@joyeecheung
Copy link
MemberAuthor

joyeecheung commented Dec 3, 2023

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1477/

@Jarred-SumnerJarred-Sumner mentioned this pull request Dec 3, 2023
Closed
@targos
Copy link
Member

targos commented Dec 3, 2023

There's a typo in the commit message (instaceof)

mcollina
mcollina approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

H4ad
H4ad approved these changes Dec 3, 2023
View reviewed changes
@tniessen
Copy link
Member

tniessen commented Dec 3, 2023

As usual, amazing work @joyeecheung :)

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56053/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56061/

@joyeecheungjoyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 5, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
@nodejs-github-botnodejs-github-bot merged commit c97322a into nodejs:mainDec 5, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2023

Landed in c97322a

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@joyeecheung@RafaelGSS
benchmark: add create-hash benchmark
b148c43
PR-URL: #51026 Refs: nodejs/performance#136 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@joyeecheung@richardlau
benchmark: add create-hash benchmark
3ab6143
PR-URL: #51026 Refs: nodejs/performance#136 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@tniessentniessentniessen approved these changes

@H4adH4adH4ad approved these changes

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung@nodejs-github-bot@targos@tniessen@mcollina@lpinca@H4ad