doc: correct tracingChannel.traceCallback()#51068
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added diagnostics_channel 
Flarnaforce-pushed the gst/diag-channel-trace-callback branch from 481f145 to e1e19b5ComparetracingChannel.traceCallback() requires a callback otherwise it throws and invalid argument error. As a result arguments are not optional. Correct the documentation to reflect that arguments are not optional. Besides that correct description regarding signaling of errors. Remove an unneeded null check in wrappedCallback() which can't happen because it's validated that callback is of type function.
Flarnaforce-pushed the gst/diag-channel-trace-callback branch from e1e19b5 to 1559cd8Compare
Qard approved these changes Dec 6, 2023
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Stephen Belanger <[email protected]>
Qard approved these changes Dec 6, 2023
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Dec 6, 2023
lpinca approved these changes Dec 7, 2023
Flarna added the author ready 
VoltrexKeyva approved these changes Dec 8, 2023
Flarna added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Dec 8, 2023
Landed in 3f942e2 |
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
tracingChannel.traceCallback() requires a callback otherwise it throws and invalid argument error. As a result arguments are not optional. Correct the documentation to reflect that arguments are not optional. Besides that correct description regarding signaling of errors. Remove an unneeded null check in wrappedCallback() which can't happen because it's validated that callback is of type function. PR-URL: #51068Fixes: #50996 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
tracingChannel.traceCallback() requires a callback otherwise it throws and invalid argument error. As a result arguments are not optional. Correct the documentation to reflect that arguments are not optional. Besides that correct description regarding signaling of errors. Remove an unneeded null check in wrappedCallback() which can't happen because it's validated that callback is of type function. PR-URL: #51068Fixes: #50996 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracingChannel.traceCallback()requires a callback otherwise it throws and invalid argument error. As a result arguments are not optional.Correct the documentation to reflect that arguments are not optional.
Besides that correct description regarding signaling of errors.
Remove an unneeded null check in
wrappedCallback()which can't happen because it's validated that callback is of type function.Fixes: #50996