doc: deprecate hash constructor#51077
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added deprecations 
marco-ippolitoforce-pushed the feat/deprecate-hash branch from 5a84550 to 3838e04Compare
anonrig reviewed Dec 6, 2023
Uh oh!
There was an error while loading. Please reload this page.
marco-ippolitoforce-pushed the feat/deprecate-hash branch from dad2f99 to 7f2906eCompare
marco-ippolitoforce-pushed the feat/deprecate-hash branch from 7f2906e to ff25004Compareanonrig approved these changes Dec 6, 2023
Member
anonrig commented Dec 6, 2023
cc @nodejs/crypto |
H4ad approved these changes Dec 7, 2023
marco-ippolito added the author ready 
jasnell approved these changes Dec 9, 2023
anonrig added the commit-queue nodejs-github-bot removed the commit-queue 
Collaborator
nodejs-github-bot commented Dec 10, 2023
Landed in ba3f721 |
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
PR-URL: #51077 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS added a commit that referenced this pull request Dec 15, 2023
Notable changes: deps: * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322 doc: * deprecate hash constructor (Marco Ippolito) #51077 * deprecate `dirent.path` (Antoine du Hamel) #51020 module: * merge config with `package_json_reader` (Yagiz Nizipli) #50322 src: * move package resolver to c++ (Yagiz Nizipli) #50322 PR-URL: TBD
Merged
RafaelGSS added a commit that referenced this pull request Dec 15, 2023
Notable changes: deps: * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322 doc: * deprecate hash constructor (Marco Ippolito) #51077 * deprecate `dirent.path` (Antoine du Hamel) #51020 module: * merge config with `package_json_reader` (Yagiz Nizipli) #50322 src: * move package resolver to c++ (Yagiz Nizipli) #50322 PR-URL: #51166
RafaelGSS added a commit that referenced this pull request Dec 15, 2023
Notable changes: deps: * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322 doc: * deprecate hash constructor (Marco Ippolito) #51077 * deprecate `dirent.path` (Antoine du Hamel) #51020 module: * merge config with `package_json_reader` (Yagiz Nizipli) #50322 src: * move package resolver to c++ (Yagiz Nizipli) #50322 PR-URL: #51166
RafaelGSS added a commit that referenced this pull request Dec 19, 2023
Notable changes: deps: * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322 doc: * deprecate hash constructor (Marco Ippolito) #51077 * deprecate `dirent.path` (Antoine du Hamel) #51020 module: * merge config with `package_json_reader` (Yagiz Nizipli) #50322 src: * move package resolver to c++ (Yagiz Nizipli) #50322 PR-URL: #51166
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51077 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hashis an internal and shouldnt be called directly but throughcreateHash():https://github.com/nodejs/node/blob/main/doc/api/crypto.md#class-hash
Calling
Hashwithout new qualifier avoids us from moving into ES6 classes.The idea is to deprecate it, and refactor it with es6 class without exposing it.
@anonrig