src: avoid shadowed string in fs_permission#51123
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Dec 11, 2023
Review requested:
|
nodejs-github-bot added c++ 
RafaelGSS approved these changes Dec 11, 2023
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Dec 11, 2023
anonrig approved these changes Dec 12, 2023
Uh oh!
There was an error while loading. Please reload this page.
codebytereforce-pushed the copy-string-fix branch 2 times, most recently from 7161204 to 7d2c4c1Compare
tniessen approved these changes Dec 12, 2023
MemberAuthor
codebytere commented Dec 12, 2023
Seeing test failures that i didn't see when running Electron's version against Node.js tests - looking into it 🤔 |
RafaelGSS requested changes Dec 18, 2023
Member
RafaelGSS left a comment
RafaelGSS left a comment There was a problem hiding this comment.
@codebytere this should fix your issue:
diff --git a/src/permission/fs_permission.h b/src/permission/fs_permission.h index 4577a73c37d..642d2dbc6ea 100644 --- a/src/permission/fs_permission.h+++ b/src/permission/fs_permission.h@@ -43,7 +43,7 @@ class FSPermission final : public PermissionBase{Node* child = children[label]; if (child == nullptr){- children[label] = new Node(prefix);+ children[label] = new Node(path_prefix); return children[label]}
codebytereforce-pushed the copy-string-fix branch from 7d2c4c1 to 988b3eaCompareMemberAuthor
codebytere commented Jan 1, 2024
@RafaelGSS done, thanks! |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jan 2, 2024
Collaborator
nodejs-github-bot commented Jan 2, 2024
Collaborator
nodejs-github-bot commented Jan 3, 2024
RafaelGSS approved these changes Jan 3, 2024
RafaelGSS added author ready nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 3, 2024
Landed in 088f4cc |
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51123 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51123 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51123 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #44004
Addresses the following shadowing issue in
fs_permission:Allows Electron to remove a patch.