Skip to content

tools: check timezone current version#51178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Dec 20, 2023
Merged

tools: check timezone current version #51178

nodejs-github-bot merged 2 commits into from
Dec 20, 2023

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolitomarco-ippolito commented Dec 16, 2023

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 16, 2023

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 16, 2023
richardlau
richardlau reviewed Dec 16, 2023
View reviewed changes
@marco-ippolito
Copy link
MemberAuthor

marco-ippolito commented Dec 16, 2023

Manual run: https://github.com/nodejs/node/actions/runs/7232306030

@marco-ippolitomarco-ippolito added the tools Issues and PRs related to the tools directory. label Dec 16, 2023
@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 19, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 19, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 19, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/51178 ✔ Done loading data for nodejs/node/pull/51178 ----------------------------------- PR info ------------------------------------ Title tools: check timezone current version (#51178) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:fix-timezone-check -> nodejs:main Labels meta, tools, author ready Commits 2 - tools: check timezone current version - fix: use tz-version.txt Committers 1 - marco-ippolito PR-URL: https://github.com/nodejs/node/pull/51178 Refs: https://github.com/nodejs/node/pull/51107 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51178 Refs: https://github.com/nodejs/node/pull/51107 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 16 Dec 2023 11:03:02 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/51178#pullrequestreview-1785181766 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51178#pullrequestreview-1785189342 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51178#pullrequestreview-1785312420 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51178 From https://github.com/nodejs/node * branch refs/pull/51178/merge -> FETCH_HEAD ✔ Fetched commits as 7a216d5fd633..05faefbb0635 -------------------------------------------------------------------------------- [main 890862f32f] tools: check timezone current version Author: marco-ippolito Date: Sat Dec 16 11:50:38 2023 +0100 1 file changed, 10 insertions(+) [main 63af976a38] fix: use tz-version.txt Author: marco-ippolito Date: Sat Dec 16 14:44:00 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) 
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 tools: check timezone current version
PR-URL: #51178
 Refs: #51107
 Reviewed-By: Richard Lau [email protected]
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Moshe Atlow [email protected]
[detached HEAD d3f8e36aa7] tools: check timezone current version
 Author: marco-ippolito [email protected]
 Date: Sat Dec 16 11:50:38 2023 +0100
 1 file changed, 10 insertions(+)
 Rebasing (3/4)
 Rebasing (4/4)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 fix: use tz-version.txt
PR-URL: #51178
 Refs: #51107
 Reviewed-By: Richard Lau [email protected]
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Moshe Atlow [email protected]
[detached HEAD 13d8c64c0b] fix: use tz-version.txt
 Author: marco-ippolito [email protected]
 Date: Sat Dec 16 14:44:00 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/7259068349

@marco-ippolitomarco-ippolito added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 19, 2023
@richardlaurichardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 20, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2023
@nodejs-github-botnodejs-github-bot merged commit 12fc7cb into mainDec 20, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 20, 2023

Landed in 12fc7cb

@nodejs-github-botnodejs-github-bot deleted the fix-timezone-check branch December 20, 2023 16:53
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@marco-ippolito@RafaelGSS
tools: check timezone current version
3759491
PR-URL: #51178 Refs: #51107 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito@richardlau
tools: check timezone current version
8e02d08
PR-URL: #51178 Refs: #51107 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@UlisesGasconUlisesGasconUlisesGascon approved these changes

@richardlaurichardlaurichardlau approved these changes

@MoLowMoLowMoLow approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@marco-ippolito@nodejs-github-bot@lpinca@UlisesGascon@richardlau@MoLow@debadree25