doc,permissions: adjust limitations and known issues section#51184
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Dec 16, 2023
Review requested:
|
RafaelGSSforce-pushed the refactor-limitations-section-pm branch from 0a147b3 to 82a82c1Compare
anonrig approved these changes Dec 17, 2023
RafaelGSS added commit-queue 
nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Dec 18, 2023
Commit Queue failed- Loading data for nodejs/node/pull/51184 ✔ Done loading data for nodejs/node/pull/51184 ----------------------------------- PR info ------------------------------------ Title doc,permissions: adjust limitations and known issues section (#51184) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:refactor-limitations-section-pm -> nodejs:main Labels doc, author ready, permission Commits 1 - doc: fix limitations and known issues in pm Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/51184 Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51184 Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 16 Dec 2023 16:21:44 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51184#pullrequestreview-1785492638 ✘ This PR needs to wait 114 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7254037180 |
RafaelGSS removed the commit-queue-failed 
Qard approved these changes Dec 21, 2023
RafaelGSS added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Dec 21, 2023
Landed in b33a1d3 |
RafaelGSS added a commit that referenced this pull request Jan 2, 2024
PR-URL: #51184 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51184 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should avoid confusion against expected behaviour vs limitations.