Skip to content

Conversation

@RafaelGSS
Copy link
Member

Clarifying native addons are restricted by default when using the permission model.

@RafaelGSSRafaelGSS added the permission Issues and PRs related to the Permission Model label Dec 16, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 16, 2023
Co-authored-by: Tobias Nießen <[email protected]>
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSSRafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 18, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 18, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51185 ✔ Done loading data for nodejs/node/pull/51185 ----------------------------------- PR info ------------------------------------ Title doc: mention native addons are restricted in pm (#51185) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:mention-addons-are-restricted -> nodejs:main Labels doc, author ready, permission Commits 2 - doc: mention native addons are restricted in pm - fixup! typo Committers 2 - RafaelGSS - GitHub PR-URL: https://github.com/nodejs/node/pull/51185 Reviewed-By: Marco Ippolito Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51185 Reviewed-By: Marco Ippolito Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 16 Dec 2023 16:26:17 GMT ✔ Approvals: 2 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51185#pullrequestreview-1785242443 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/51185#pullrequestreview-1787536430 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51185 From https://github.com/nodejs/node * branch refs/pull/51185/merge -> FETCH_HEAD ✔ Fetched commits as 135948d584ab..2483f9125ae2 -------------------------------------------------------------------------------- [main 354bade593] doc: mention native addons are restricted in pm Author: RafaelGSS Date: Sat Dec 16 13:25:34 2023 -0300 1 file changed, 1 insertion(+), 1 deletion(-) [main 7992aad966] fixup! typo Author: Rafael Gonzaga Date: Mon Dec 18 10:43:41 2023 -0300 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) 

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: mention native addons are restricted in pm

PR-URL: #51185
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Michael Dawson [email protected]

[detached HEAD 41b273f05a] doc: mention native addons are restricted in pm
Author: RafaelGSS [email protected]
Date: Sat Dec 16 13:25:34 2023 -0300
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! typo

Co-authored-by: Tobias Nießen [email protected]
PR-URL: #51185
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Michael Dawson [email protected]

[detached HEAD 99378d8197] fixup! typo
Author: Rafael Gonzaga [email protected]
Date: Mon Dec 18 10:43:41 2023 -0300
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/7254037180

@RafaelGSSRafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 19, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2023
@nodejs-github-botnodejs-github-bot merged commit 27d953d into nodejs:mainDec 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 27d953d

RafaelGSS added a commit that referenced this pull request Jan 2, 2024
PR-URL: #51185 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51185 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.permissionIssues and PRs related to the Permission Model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@RafaelGSS@nodejs-github-bot@tniessen@richardlau@mhdawson@marco-ippolito