doc: remove version from maintaining-dependencies.md#51195
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Those create unreasonable maintenance burden as updating one dependency will conflict with another one. It's unclear we get much value out from duplicating this information in this document, so this commit removes it
nodejs-github-bot commented Dec 17, 2023
Review requested:
|
I have mixed feelings, the maintainance burden is annoying but not having the dependency version tracked in a readable way sounds bad too. |
aduh95 commented Dec 17, 2023
I think the point of having a workflow that automatically updates our deps is to stay up-to-date, and not burn out our volunteers' time with busy work, and if you look at the number of open PRs for dependency updates, you can see we're falling behind – because no one wants to do the work of fixing conflicts, I myself regret spending the time I spent on this when I see that as soon as one PR has landed, it has undone the work I just did by creating new conflicts.
OK but not landing the upgrade PRs is worse I think, and that's the current situation. The current situation has to change if you want me to keep interacting with those upgrade PRs, it's simply not worth my time to try to fix an endless flow of git conflicts – and more importantly, it's not worth releasers' time either. If you want a readable way to get the information, hopefully using git is enough? For example, if you go to https://github.com/nodejs/node/tree/main/deps, GitHub web UI will list the last commit and that's often the last update with the version number: |
targos left a comment
targos left a comment There was a problem hiding this comment.
I already spent a long time (accumulated) fixing conflicts in LTS
aduh95 added author ready 
nodejs-github-bot removed the commit-queue nodejs-github-bot commented Dec 19, 2023
Landed in 898149f |
Those create unreasonable maintenance burden as updating one dependency will conflict with another one. It's unclear we get much value out from duplicating this information in this document, so this commit removes it PR-URL: nodejs#51195 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
mhdawson left a comment
mhdawson left a comment There was a problem hiding this comment.
LGTM. I think this made sense when we were doing it manually, but now that we have automation doing the updates the conflicts are not worty the overhead.
Those create unreasonable maintenance burden as updating one dependency will conflict with another one. It's unclear we get much value out from duplicating this information in this document, so this commit removes it PR-URL: #51195 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Those create unreasonable maintenance burden as updating one dependency will conflict with another one. It's unclear we get much value out from duplicating this information in this document, so this commit removes it PR-URL: #51195 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
8 participants
Those create unreasonable maintenance burden as updating one dependency will conflict with another one. It's unclear we get much value out from duplicating this information in this document, so this PR removes it.