test: use tmpdir.refresh() in test-esm-json.mjs#51205
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added esm 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Dec 18, 2023
Use `tmpdir.refresh()` in `test/es-module/test-esm-json.mjs` so that the temporary directory is removed when the test exits.
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Dec 18, 2023
Collaborator
nodejs-github-bot commented Dec 18, 2023
Collaborator
nodejs-github-bot commented Dec 19, 2023
H4ad approved these changes Dec 19, 2023
H4ad added the author ready 
debadree25 approved these changes Dec 20, 2023
debadree25 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Dec 20, 2023
Landed in 0390a1d |
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
Use `tmpdir.refresh()` in `test/es-module/test-esm-json.mjs` so that the temporary directory is removed when the test exits. PR-URL: #51205 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Use `tmpdir.refresh()` in `test/es-module/test-esm-json.mjs` so that the temporary directory is removed when the test exits. PR-URL: #51205 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
tmpdir.refresh()intest/es-module/test-esm-json.mjsso that the temporary directory is removed when the test exits.