Skip to content

permission: fix wildcard when children > 1#51209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 21, 2023
Merged

permission: fix wildcard when children > 1 #51209

nodejs-github-bot merged 1 commit into from
Dec 21, 2023

Conversation

@RafaelGSS
Copy link
Member

@RafaelGSSRafaelGSS commented Dec 18, 2023

Fixes: #50659

@RafaelGSSRafaelGSS added the permission Issues and PRs related to the Permission Model label Dec 18, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 18, 2023

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 18, 2023
@RafaelGSSRafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56375/

@RafaelGSSRafaelGSSforce-pushed the handle-wildcard-with-children-pm branch from b417898 to d833469CompareDecember 19, 2023 19:34
@RafaelGSSRafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 19, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56398/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56431/

ShogunPanda
ShogunPanda approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@ShogunPandaShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RafaelGSSRafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
@nodejs-github-botnodejs-github-bot merged commit 3f2e234 into nodejs:mainDec 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2023

Landed in 3f2e234

RafaelGSS added a commit that referenced this pull request Jan 2, 2024
@RafaelGSS
permission: fix wildcard when children > 1
8f4325d
PR-URL: #51209Fixes: #50659 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
Merged
RafaelGSS added a commit that referenced this pull request Feb 14, 2024
@RafaelGSS
test,doc: clarify wildcard usage
834ae37
Follow-up: #51209 PR-URL: nodejs-private/node-private#517 Fixes: https://hackerone.com/bugs?subject=nodejs&report_id=2257156 CVE-ID: CVE-2024-21890
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 20, 2024
@RafaelGSS@rdw-msft
test,doc: clarify wildcard usage
370fa78
Follow-up: nodejs#51209 PR-URL: https://github.com/nodejs-private/node-private/pull/517 Fixes: https://hackerone.com/bugs?subject=nodejs&report_id=2257156 CVE-ID: CVE-2024-21890
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@RafaelGSS@marco-ippolito
test,doc: clarify wildcard usage
ef3eea2
Follow-up: nodejs/node#51209 PR-URL: nodejs-private/node-private#517 Fixes: https://hackerone.com/bugs?subject=nodejs&report_id=2257156 CVE-ID: CVE-2024-21890
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@RafaelGSS
permission: fix wildcard when children > 1
d01dd42
PR-URL: nodejs/node#51209Fixes: nodejs/node#50659 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rich Trott <[email protected]>
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@RafaelGSS
test,doc: clarify wildcard usage
d6da413
Follow-up: nodejs/node#51209 PR-URL: nodejs-private/node-private#517 Fixes: https://hackerone.com/bugs?subject=nodejs&report_id=2257156 CVE-ID: CVE-2024-21890
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes

@QardQardQard approved these changes

@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.permissionIssues and PRs related to the Permission Model

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Experimental permission wildcards seem to not be additive

5 participants

@RafaelGSS@nodejs-github-bot@ShogunPanda@Qard@Trott