Skip to content

test: skip test-watch-mode-inspect on arm#51210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 22, 2023
Merged

test: skip test-watch-mode-inspect on arm #51210

nodejs-github-bot merged 1 commit into from
Dec 22, 2023

Conversation

@mhdawson
Copy link
Member

@mhdawsonmhdawson commented Dec 18, 2023

Refs: #49933

  • SKIP instead of mark FLAKY as tests seems to fail builds through left over processes

This seems to fail in almost every CI run look at.

@mhdawson
test: skip test-watch-mode-inspect on arm
64f8f28
Refs: nodejs#49933 - SKIP instead of mark FLAKY as tests seems to fail builds through left over processe Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 18, 2023
@mhdawsonmhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 20, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56410/

@jasnelljasnell added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Dec 22, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
@nodejs-github-botnodejs-github-bot merged commit 4f3261f into nodejs:mainDec 22, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2023

Landed in 4f3261f

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@mhdawson@RafaelGSS
test: skip test-watch-mode-inspect on arm
3db376f
Refs: #49933 - SKIP instead of mark FLAKY as tests seems to fail builds through left over processe Signed-off-by: Michael Dawson <[email protected]> PR-URL: #51210 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@mhdawson@richardlau
test: skip test-watch-mode-inspect on arm
6e62e64
Refs: #49933 - SKIP instead of mark FLAKY as tests seems to fail builds through left over processe Signed-off-by: Michael Dawson <[email protected]> PR-URL: #51210 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhdawson@nodejs-github-bot@jasnell@lpinca