test: fix flaky test-dgram-pingpong#5125
Closed
+21 −65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added dgram 
MemberAuthor
Trott commented Feb 6, 2016
| assert.equal('PONG',msg.toString('ascii')); | ||
| count+=1; | ||
| client.on('message',function(msg){ |
Contributor
There was a problem hiding this comment.
Perhaps the callback here should be wrapped with common.mustCall(..., N)?
MemberAuthor
There was a problem hiding this comment.
I could go either way on it. I left it without common.mustCall() and used the assert.strictEqual(pongsReceived, N); instead so that it would be readily apparent that it's the analogous check to assert(pingsReceived >= N);.
MemberAuthor
Trott commented Feb 6, 2016
Stress test with this fix: Stress test on current master (should show lots of failures): |
MemberAuthor
Trott commented Feb 6, 2016
So, looking at the stress test results, these changes greatly reduce the flakiness but don't eliminate it... More to be done... |
MemberAuthor
Trott commented Feb 7, 2016
OK, greatly revised. @mscdex, PTAL. |
MemberAuthor
Trott commented Feb 7, 2016
MemberAuthor
Trott commented Feb 7, 2016
Stress test passed. CI failure is unrelated test. |
Contributor
mscdex commented Feb 7, 2016
LGTM |
Member
There was a problem hiding this comment.
Binding this suggests it's somehow important but it's not, is it? It's always undefined, if I read the diff right.
Member
bnoordhuis commented Feb 7, 2016
LGTM with a nit. |
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: nodejs#4526
MemberAuthor
Trott commented Feb 7, 2016
Nit addressed. CI again: https://ci.nodejs.org/job/node-test-pull-request/1579/ |
Member
jasnell commented Feb 7, 2016
LGTM |
jasnell pushed a commit that referenced this pull request Feb 7, 2016
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Feb 7, 2016
Landed in 987e9e3 |
rvagg pushed a commit that referenced this pull request Feb 8, 2016
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 9, 2016
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: nodejs#4526 PR-URL: nodejs#5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no guarantee UDP messages will be received. Accommodate the
occasional dropped message.
This is a functionality test, not a performance benchmark. Speed up the
test by sending 5 messages per server rather than 500.
Fixes: #4526