Fix VScode "Reopen in Container"#51271
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bnb approved these changes Dec 26, 2023
Contributor
There was a problem hiding this comment.
This seems to be correct, based off this documentation. My understanding is that there's not a really great way to test something like this without merging - happy to be told I'm wrong, but this LGTM as the person who originally built the devcontainer.
If it's not, I'm happy to take responsibility for fixing it 👍🏻
anonrig added the author ready 
anonrig reviewed Dec 26, 2023
Uh oh!
There was an error while loading. Please reload this page.
lpinca approved these changes Dec 30, 2023
aduh95 added the commit-queue 
nodejs-github-bot removed the commit-queue 
Collaborator
nodejs-github-bot commented Dec 31, 2023
Landed in 5fb6305 |
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51271 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51271 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51271 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make "Reopen in Container" command work in Visual Studio code.