tools: update inspector_protocol to 83b1154#51309
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Dec 29, 2023
Review requested:
|
nodejs-github-bot added c++ 
cola119 added tools 
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
cola119 added the trace_events This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Dec 30, 2023
MemberAuthor
cola119 commented Jan 10, 2024
@nodejs/inspector @nodejs/v8-inspector |
Contributor
eugeneo commented Jan 10, 2024
I would like to confirm that this is not hand-coded but came from the V8 repository. I do not remember the details, but it is preferred to minimize the divergence. |
Contributor
eugeneo commented Jan 10, 2024
Oh, sorry, ignore my previous comment - noticed the link at the top. Approved, FWIW - I'm no longer a committer :) |
eugeneo approved these changes Jan 10, 2024
Member
targos commented Jan 10, 2024
@nodejs/cpp-reviewers |
Qard approved these changes Jan 11, 2024
cola119 added author ready nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 11, 2024
Landed in d102d16 |
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
PR-URL: nodejs#51309 Reviewed-By: Stephen Belanger <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
PR-URL: nodejs#51309 Reviewed-By: Stephen Belanger <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51309 Reviewed-By: Stephen Belanger <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51309 Reviewed-By: Stephen Belanger <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51309 Reviewed-By: Stephen Belanger <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New revision: 83b1154a9661d22bba9a368d368214cc20880419
This updates the usages of the protocol types to the new definitions, using std::vector-based implementations of protocol::Array.
This changes the usages of Array in Node inspector as following:
vec[i]std::make_uniquefor creationemplace_backto insert elements