quic: various additional cleanups, fixes in Endpoint#51310
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Dec 29, 2023
Review requested:
|
nodejs-github-bot added c++ 
jasnell added the quic 
anonrig approved these changes Dec 29, 2023
Uh oh!
There was an error while loading. Please reload this page.
jasnellforce-pushed the quic-part-10 branch 4 times, most recently from 10c3f63 to dee88f8Compare This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Qard reviewed Dec 30, 2023
Member
Qard left a comment
Qard left a comment There was a problem hiding this comment.
Did a quick skim and left some comments. Will have to find time for a more in-depth review another time.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
jasnell added author ready jasnell added a commit that referenced this pull request Jan 6, 2024
PR-URL: #51310 Reviewed-By: Yagiz Nizipli <[email protected]>
MemberAuthor
jasnell commented Jan 6, 2024
Landed in 3605574 |
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
PR-URL: nodejs#51310 Reviewed-By: Yagiz Nizipli <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
PR-URL: nodejs#51310 Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51310 Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
marco-ippolito added the dont-land-on-v20.x Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More incremental implementation of quic/http3
Adds debug logging details, starts to add the http3 internal impl