fs,test: add URL to string to fs.watch#51346
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added fs 
Signed-off-by: RafaelGSS <[email protected]>
RafaelGSSforce-pushed the validate-params-fs-watch branch from 0161109 to c81d891Compare
anonrig approved these changes Jan 3, 2024
MoLow approved these changes Jan 3, 2024
aduh95 reviewed Jan 3, 2024
| })); | ||
| assert.throws(()=>{ | ||
| fs.watch(blockedFileURL,()=>{}); | ||
| },common.expectsError({ |
Contributor
There was a problem hiding this comment.
FWIW the expectsError is unnecessary
Suggested change
| },common.expectsError({ | |
| },{ |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jan 3, 2024
lpinca approved these changes Jan 3, 2024
benjamingr approved these changes Jan 3, 2024
Collaborator
nodejs-github-bot commented Jan 3, 2024
Collaborator
nodejs-github-bot commented Jan 4, 2024
UlisesGascon approved these changes Jan 4, 2024
RafaelGSS added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 5, 2024
Landed in 22f4482 |
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
Signed-off-by: RafaelGSS <[email protected]> PR-URL: nodejs#51346 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
Signed-off-by: RafaelGSS <[email protected]> PR-URL: nodejs#51346 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #51346 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #51346 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #51346 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if the URL is expected to be supported through
fs.watch.@nodejs/fs