Skip to content

tools: fix version parsing in brotli update script#51373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jan 7, 2024
Merged

tools: fix version parsing in brotli update script #51373

nodejs-github-bot merged 1 commit into from
Jan 7, 2024

Conversation

@richardlau
Copy link
Member

@richardlaurichardlau commented Jan 4, 2024

Update tools/dep_updaters/update-brotli.sh to parse the current version of brotli from the newer macros BROTLI_VERSION_MAJOR, BROTLI_VERSION_MINOR and BROTLI_VERSION_PATCH.

Refs: #50804
Refs: nodejs/security-wg#1181

e.g. Failing in https://github.com/nodejs/node/actions/runs/7367214596/job/20050242756

./tools/dep_updaters/update-brotli.sh: 29: arithmetic expression: expecting ')': " (110\ >> 24) & 0xff "Error: Process completed with exit code 2.

@richardlau
tools: fix version parsing in brotli update script
a5b0005
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 4, 2024

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 4, 2024
@richardlaurichardlau mentioned this pull request Jan 4, 2024
Closed
@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 4, 2024
@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2024
@nodejs-github-botnodejs-github-bot merged commit 15b38fa into nodejs:mainJan 7, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 7, 2024

Landed in 15b38fa

@richardlaurichardlau deleted the fixbrotliupdater branch January 7, 2024 15:42
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@richardlau@marco-ippolito
tools: fix version parsing in brotli update script
c63f465
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: nodejs#51373 Refs: nodejs#50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@richardlau@Medhansh404
tools: fix version parsing in brotli update script
54cda22
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: nodejs#51373 Refs: nodejs#50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
@richardlau@targos
tools: fix version parsing in brotli update script
29492e2
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
tools: fix version parsing in brotli update script
d460750
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
tools: fix version parsing in brotli update script
4ce2ecb
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@richardlau@nodejs-github-bot@lpinca@targos@marco-ippolito