Skip to content

tools: remove openssl 1 update workflow#51378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jan 7, 2024
Merged

tools: remove openssl 1 update workflow #51378

nodejs-github-bot merged 1 commit into from
Jan 7, 2024

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolitomarco-ippolito commented Jan 5, 2024

Remove update workflow for openssl v1 since it's no longer in our releases.
Fixes: nodejs/security-wg#1182

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 5, 2024•
edited by marco-ippolito
Loading

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 5, 2024
@marco-ippolitomarco-ippolito added tools Issues and PRs related to the tools directory. openssl Issues and PRs related to the OpenSSL dependency. labels Jan 5, 2024
@marco-ippolitomarco-ippolito changed the title Remove openssl 1 updatetools: remove openssl 1 updateJan 5, 2024
@marco-ippolitomarco-ippolito changed the title tools: remove openssl 1 updatetools: remove openssl 1 update workflowJan 5, 2024
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 5, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/56680/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 5, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/56682/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 5, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/56683/

@marco-ippolitomarco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 5, 2024
mhdawson
mhdawson approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco-ippolitomarco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2024
@nodejs-github-botnodejs-github-bot merged commit 5d412a7 into nodejs:mainJan 7, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 7, 2024

Landed in 5d412a7

marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@marco-ippolito
tools: remove openssl v1 update script
aa67c16
PR-URL: nodejs#51378Fixes: nodejs/security-wg#1182 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@marco-ippolito@Medhansh404
tools: remove openssl v1 update script
f4158cb
PR-URL: nodejs#51378Fixes: nodejs/security-wg#1182 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
@marco-ippolito@targos
tools: remove openssl v1 update script
35f33d3
PR-URL: #51378Fixes: nodejs/security-wg#1182 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito@richardlau
tools: remove openssl v1 update script
304c64f
PR-URL: #51378Fixes: nodejs/security-wg#1182 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito@richardlau
tools: remove openssl v1 update script
e658208
PR-URL: #51378Fixes: nodejs/security-wg#1182 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@richardlaurichardlaurichardlau approved these changes

@mhdawsonmhdawsonmhdawson approved these changes

@RafaelGSSRafaelGSSRafaelGSS approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.opensslIssues and PRs related to the OpenSSL dependency.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop openssl-v1-update

8 participants

@marco-ippolito@nodejs-github-bot@benjamingr@lpinca@targos@richardlau@mhdawson@RafaelGSS