Skip to content

Conversation

@lucshi
Copy link

@lucshilucshi commented Jan 10, 2024

Fixed: #50571

Before applying this PR, the top functions are reading test JS file, instead of real logic code of "equal".
After increasing the iteration value, the test case behaved as expected to trigger equal.

Below is the benefit after changing the iteration value. Now it reflects the real performance but brought no much overhead on execution duration.

<style> </style>
after PRbefore PRbenefit
assert/deepequal-map.jsmethod="deepEqual_primitiveOnly"strict=059545.1848334260.41796174%
assert/deepequal-map.jsmethod="deepEqual_objectOnly"strict=03638.4747773392.21504107%
assert/deepequal-map.jsmethod="deepEqual_mixed"strict=06454.1555495799.864942111%
assert/deepequal-map.jsmethod="notDeepEqual_primitiveOnly"strict=0102229.469347497.09769215%
assert/deepequal-map.jsmethod="notDeepEqual_objectOnly"strict=06720.7155936003.967109112%
assert/deepequal-map.jsmethod="notDeepEqual_mixed"strict=0794615.0527348783.2696228%
assert/deepequal-map.jsmethod="deepEqual_primitiveOnly"strict=156371.1559934136.76485165%
assert/deepequal-map.jsmethod="deepEqual_objectOnly"strict=13605.963193395.947981106%
assert/deepequal-map.jsmethod="deepEqual_mixed"strict=17022.1938136173.548626114%
assert/deepequal-map.jsmethod="notDeepEqual_primitiveOnly"strict=1101741.219648439.2862210%
assert/deepequal-map.jsmethod="notDeepEqual_objectOnly"strict=16150.3761615650.374937109%
assert/deepequal-map.jsmethod="notDeepEqual_mixed"strict=1644760.3742337935.3367191%

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Jan 10, 2024
@legendecaslegendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2024
@nodejs-github-botnodejs-github-bot merged commit 6c080f6 into nodejs:mainFeb 28, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 6c080f6

@lucshilucshi deleted the benchmark/assert/deepequal-map.js branch February 29, 2024 01:14
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@richardlaurichardlau mentioned this pull request Mar 25, 2024
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assertIssues and PRs related to the assert subsystem.benchmarkIssues and PRs related to the benchmark subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes

3 participants

@lucshi@nodejs-github-bot@legendecas