suppress the output of rd %config%

[liudonghua123]

I noticed the confusing error like message The system cannot find the file specified. in the CIs and on my first build locally. It's really annoying.

And after some debugging, I found the root case of this error message.

Then this simple pr comes for it!

See also #40749 (comment).

[marco-ippolito]

cc @nodejs/build-files

[tniessen]

cc @nodejs/platform-windows

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56756/

[H4ad]

Thanks for the PR!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56760/

[liudonghua123]

@H4ad Hi, could we merge the pull request.

I noticed some warnings/errors as follows in https://ci.nodejs.org/job/node-test-commit/67906/console, but I couldn't help to fix it.

20:26:32 [email protected]: Permission denied (publickey). 20:26:32 fatal: Could not read from remote repository. 

[tniessen]

Would something like this work instead to not suppress other errors?

Suggested change

	:: Suppress "The system cannot find the file specified." on every clean build.
	rd%config%>nul2>nul
	if exists %config%rd%config%

[liudonghua123]

The correct syntax should be
"IF EXIST file command". However, check whether the file exists doesn't help a lot here because it's safe to remove the link even the link doesn't exists. Both of them works, and RD directly is just more simpler IMO.

[tniessen]

On the other hand, if %config% doesn't exist, it's not necessary to invoke rd, and when it does exist, this approach doesn't silently ignore the output of rd.

[liudonghua123]

Yes, I updated this pr. Thanks! 😄

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56774/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56776/

[tniessen]

Note @ whoever decides to merge this: the commit queue would incorrectly use the first commit message as the final commit message, so either land this manually or force-push to the PR branch with an amended commit message (but that requires a fresh CI).

[liudonghua123]

Note @ whoever decides to merge this: the commit queue would incorrectly use the first commit message as the final commit message, so either land this manually or force-push to the PR branch with an amended commit message (but that requires a fresh CI).

@tniessen so what should I do? Amend the two commits into one, change the commit message then force-push?

[tniessen]

That option would be the easiest solution for us, then we only need to re-run CI on the squashed commit :)

[liudonghua123]

@tniessen Thanks, now I reset the last two commits and force pushed the amended log message commit.

[tniessen]

Thank you @liudonghua123!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56794/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56808/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56870/

[nodejs-github-bot]

Landed in b9a4279