Skip to content

Conversation

@aduh95
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 12, 2024
@H4ad
Copy link
Member

H4ad commented Jan 12, 2024

Do you have any reason/follow-up to link to this change?

I mean, they make sense but just for historical reasons. If not, is not a problem.

@aduh95
Copy link
ContributorAuthor

Do you have any reason/follow-up to link to this change?

I mean, they make sense but just for historical reasons.

I don't know about historical reasons, the reason I'm suggesting adding those is for practical reasons, and because the time of volunteers who take care of offboarding folks is precious.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 12, 2024
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51440 ✔ Done loading data for nodejs/node/pull/51440 ----------------------------------- PR info ------------------------------------ Title doc: add links in `offboarding.md` (#51440) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:offboard-links -> nodejs:main Labels doc, author ready Commits 2 - doc: add links in `offboarding.md` - EOL EOF Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/51440 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Richard Lau Reviewed-By: Marco Ippolito Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51440 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Richard Lau Reviewed-By: Marco Ippolito Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 12 Jan 2024 09:19:20 GMT ✔ Approvals: 6 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51440#pullrequestreview-1818128038 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/51440#pullrequestreview-1818197414 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51440#pullrequestreview-1818687521 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/51440#pullrequestreview-1818714984 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51440#pullrequestreview-1818941152 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/51440#pullrequestreview-1819163113 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51440 From https://github.com/nodejs/node * branch refs/pull/51440/merge -> FETCH_HEAD ✔ Fetched commits as c25878d370c6..d23605cf26bf -------------------------------------------------------------------------------- [main 2a49384c0f] doc: add links in `offboarding.md` Author: Antoine du Hamel Date: Fri Jan 12 10:11:11 2024 +0100 1 file changed, 9 insertions(+), 4 deletions(-) [main e77e6cbefc] EOL EOF Author: Antoine du Hamel Date: Fri Jan 12 15:30:07 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) 

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: add links in offboarding.md

PR-URL: #51440
Reviewed-By: Vinícius Lourenço Claro Cardoso [email protected]
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Michael Dawson [email protected]

[detached HEAD 781be42f07] doc: add links in offboarding.md
Author: Antoine du Hamel [email protected]
Date: Fri Jan 12 10:11:11 2024 +0100
1 file changed, 9 insertions(+), 4 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
EOL EOF

PR-URL: #51440
Reviewed-By: Vinícius Lourenço Claro Cardoso [email protected]
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Michael Dawson [email protected]

[detached HEAD 96442cb108] EOL EOF
Author: Antoine du Hamel [email protected]
Date: Fri Jan 12 15:30:07 2024 +0100
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/7518258776

@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 14, 2024
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 14, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2024
@nodejs-github-botnodejs-github-bot merged commit 9fce1df into nodejs:mainJan 14, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 9fce1df

@aduh95aduh95 deleted the offboard-links branch January 14, 2024 21:59
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
PR-URL: nodejs#51440 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51440 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51440 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51440 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@aduh95@nodejs-github-bot@H4ad@benjamingr@lpinca@UlisesGascon@richardlau@mhdawson@aymen94@marco-ippolito