Skip to content

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolitomarco-ippolito commented Jan 12, 2024

The function isWebAssemblyCompiledModule has actually already been removed from the codebase with this commit.
I just updated documentation and marked it as EOL since the code isn't there anymore and it could not be runtime deprecated.
Although eol deprecations are semver major, I would not mark it as such because its only a documentation update.

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 12, 2024
@marco-ippolitomarco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2024
@marco-ippolitomarco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 13, 2024
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 14, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51442 ✔ Done loading data for nodejs/node/pull/51442 ----------------------------------- PR info ------------------------------------ Title doc: mark isWebAssemblyCompiledModule as eol (#51442) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/eol-isWebAssemblyCompiledModule -> nodejs:main Labels doc, author ready Commits 3 - doc: mark isWebAssemblyCompiledModule eol - Update doc/api/deprecations.md - Update doc/api/deprecations.md Committers 2 - marco-ippolito - GitHub PR-URL: https://github.com/nodejs/node/pull/51442 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51442 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 12 Jan 2024 10:17:00 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/51442#pullrequestreview-1818730724 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51442#pullrequestreview-1818964796 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/51442#pullrequestreview-1819705315 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ee5cfcb5f7..9fce1df548 main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - a5c4c2fa40 doc: add links in `offboarding.md` - 9fce1df548 doc: add links in `offboarding.md` -------------------------------------------------------------------------------- HEAD is now at 9fce1df548 doc: add links in `offboarding.md` ✔ Reset to origin/main - Downloading patch for 51442 From https://github.com/nodejs/node * branch refs/pull/51442/merge -> FETCH_HEAD ✔ Fetched commits as 9fce1df54850..ccd0dd616fa4 -------------------------------------------------------------------------------- [main 238f3b8897] doc: mark isWebAssemblyCompiledModule eol Author: marco-ippolito Date: Fri Jan 12 11:10:32 2024 +0100 2 files changed, 5 insertions(+), 23 deletions(-) [main 8f2dbcf5d6] Update doc/api/deprecations.md Author: Marco Ippolito Date: Fri Jan 12 14:37:12 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main 1a3a8dc6fb] Update doc/api/deprecations.md Author: Marco Ippolito Date: Fri Jan 12 14:37:27 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6) 

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: mark isWebAssemblyCompiledModule eol

PR-URL: #51442
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Mohammed Keyvanzadeh [email protected]

[detached HEAD c3fc65f6dc] doc: mark isWebAssemblyCompiledModule eol
Author: marco-ippolito [email protected]
Date: Fri Jan 12 11:10:32 2024 +0100
2 files changed, 5 insertions(+), 23 deletions(-)
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/deprecations.md

Co-authored-by: Richard Lau [email protected]
PR-URL: #51442
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Mohammed Keyvanzadeh [email protected]

[detached HEAD 87f6cf496b] Update doc/api/deprecations.md
Author: Marco Ippolito [email protected]
Date: Fri Jan 12 14:37:12 2024 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/deprecations.md

Co-authored-by: Richard Lau [email protected]
PR-URL: #51442
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Mohammed Keyvanzadeh [email protected]

[detached HEAD acd5931799] Update doc/api/deprecations.md
Author: Marco Ippolito [email protected]
Date: Fri Jan 12 14:37:27 2024 +0100
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/7518569308

@marco-ippolitomarco-ippolito added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 14, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2024
@nodejs-github-botnodejs-github-bot merged commit 7496bc4 into nodejs:mainJan 14, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 7496bc4

Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
PR-URL: nodejs#51442 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51442 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51442 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51442 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@marco-ippolito@nodejs-github-bot@benjamingr@lpinca@richardlau@VoltrexKeyva