Skip to content

Conversation

@big-kahuna-burger
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 15, 2024
@big-kahuna-burgerbig-kahuna-burger changed the title docs: update typo in security-release-process.mddoc: update typo in security-release-process.mdJan 15, 2024
@big-kahuna-burger
Copy link
ContributorAuthor

PTAL @mhdawson

Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@big-kahuna-burger
Copy link
ContributorAuthor

big-kahuna-burger commented Jan 17, 2024

@mhdawson force push addressed same issue in other location and made commit lint eventually pass

@legendecaslegendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2024
@nodejs-github-botnodejs-github-bot merged commit 32ce183 into nodejs:mainJan 18, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 32ce183

@big-kahuna-burgerbig-kahuna-burger deleted the patch-1 branch January 18, 2024 06:36
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
PR-URL: nodejs#51475 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 22, 2024
PR-URL: nodejs#51475 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
PR-URL: nodejs#51475 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51475 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
PR-URL: nodejs#51475 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51475 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51475 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@big-kahuna-burger@nodejs-github-bot@legendecas@mhdawson