Ensure there's a channel before trying to send on it#5148
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added child_process 
Contributor
mscdex commented Feb 9, 2016
Maybe it would be easier to backport #4418? That way there's less of a delta between v0.12 and modern branches. I'm kind of surprised it wasn't already backported really. I wonder if v0.10 needs this as well.... |
ContributorAuthor
arlolra commented Feb 9, 2016
@mscdex definitely backport and abandon this. And it does look like v0.10 needs it as well. |
Contributor
mscdex commented Feb 9, 2016
v0.12 should be fixed by #5153. I wasn't able to reproduce the problem on v0.10. |
ContributorAuthor
arlolra commented Feb 9, 2016
Closing in favour of #5153 |
This was referenced Apr 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a trace on
v0.12.9,_disconnectnulls out the channel, but admits there may still be some buffering. If that's aNODE_HANDLEmessage, it'll attempt this ack.handleMessagehas a similar check.cc/ @inez