Allow checking the test result from afterEach#51485
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jan 16, 2024
Review requested:
|
nodejs-github-bot added needs-ci 
tims-bsquareforce-pushed the test-after-each-access-result branch from 9a559a9 to f748568Compare
ContributorAuthor
tims-bsquare commented Jan 16, 2024
Amended the commit message to match guidelines |
MoLow reviewed Jan 16, 2024
Uh oh!
There was an error while loading. Please reload this page.
benjamingr approved these changes Jan 17, 2024
MoLow approved these changes Jan 18, 2024
MoLow added author ready 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jan 18, 2024
aduh95 reviewed Jan 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Jan 19, 2024
Collaborator
nodejs-github-bot commented Jan 19, 2024
MoLow added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 19, 2024
Landed in d755f1a |
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 22, 2024
PR-URL: nodejs#51485 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
PR-URL: nodejs#51485 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51485 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
PR-URL: nodejs#51485 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51485 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51485 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
This was referenced Aug 1, 2025
Xstoudi added a commit to Xstoudi/node that referenced this pull request Dec 28, 2025
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: nodejs#59321 Refs: nodejs#51485 Refs: nodejs#59322
Xstoudi added a commit to Xstoudi/node that referenced this pull request Dec 28, 2025
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: nodejs#59321 Refs: nodejs#51485 Refs: nodejs#59322
Xstoudi added a commit to Xstoudi/node that referenced this pull request Dec 28, 2025
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: nodejs#59321 Refs: nodejs#51485 Refs: nodejs#59322
Xstoudi added a commit to Xstoudi/node that referenced this pull request Dec 28, 2025
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: nodejs#59321 Refs: nodejs#51485 Refs: nodejs#59322 Co-authored-by: SimonSchick <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Dec 30, 2025
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: #59321 Refs: #51485 Refs: #59322 Co-authored-by: SimonSchick <[email protected]> PR-URL: #61185 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets users check the result of the test in the afterEach hook. It's handy for example when doing Selenium tests where if a test fails you want to take a screenshot then do some cleanup.