Skip to content

Conversation

@pluris
Copy link
Contributor

I updated jsdoc due to inconsistency between documentation and jsdoc.

  • filehandle.createWriteStream()

    node/doc/api/fs.md

    Lines 336 to 344 in e133e51

    * `options`{Object}
    * `encoding`{string} **Default:** `'utf8'`
    * `autoClose`{boolean} **Default:** `true`
    * `emitClose`{boolean} **Default:** `true`
    * `start`{integer}
    * `highWaterMark`{number} **Default:** `16384`
    * `flush`{boolean} If `true`, the underlying file descriptor is flushed
    prior to closing it. **Default:** `false`.
    * Returns:{fs.WriteStream}

  • fs.appendFile()

    node/doc/api/fs.md

    Lines 2105 to 2114 in e133e51

    * `path`{string|Buffer|URL|number} filename or file descriptor
    * `data`{string|Buffer}
    * `options`{Object|string}
    * `encoding`{string|null} **Default:** `'utf8'`
    * `mode`{integer} **Default:** `0o666`
    * `flag`{string} See [support of file system `flags`][]. **Default:** `'a'`.
    * `flush`{boolean} If `true`, the underlying file descriptor is flushed
    prior to closing it. **Default:** `false`.
    * `callback`{Function}
    * `err`{Error}

@nodejs-github-botnodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jan 16, 2024
@deokjinkimdeokjinkim added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 20, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@deokjinkimdeokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2024
@nodejs-github-botnodejs-github-bot merged commit 27d839f into nodejs:mainJan 20, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 27d839f

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
targos pushed a commit that referenced this pull request Feb 15, 2024
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pluris@nodejs-github-bot@lpinca@deokjinkim