tools: remove excessive comments from .eslintrc#5151
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
Trott commented Feb 9, 2016
Once #5135 lands, the diff should look like what you see at Trott@cc99a75 |
.eslintrc Outdated
Contributor
There was a problem hiding this comment.
Maybe also remove list: from each section?
Contributor
silverwind commented Feb 9, 2016
LGTM with suggestion. |
Contributor
silverwind commented Feb 9, 2016
Oh by the way, the commit title |
Trott changed the title MemberAuthor
Trott commented Feb 9, 2016
Commit message fixed, |
MemberAuthor
Trott commented Feb 9, 2016
MemberAuthor
Trott commented Feb 9, 2016
CI looks good, except for a Windows buildbot issue on one host. Shouldn't really affect anything because this is a linting tool change and nothing else, but I like my CIs green (or at least yellow), so let's try again: |
Member
jasnell commented Feb 10, 2016
#5135 landed. Is this one ready to go? Looks like it might need a quick rebase. |
The comments make the config hard to scan. They do not provide any information that isn't in the documentation links referred to in comments (that are not being removed here). Additionally, all rule config sections are alphabetically ordered for easier scanning etc.
MemberAuthor
Trott commented Feb 10, 2016
Rebased. New CI: https://ci.nodejs.org/job/node-test-pull-request/1627/ |
Contributor
silverwind commented Feb 10, 2016
LGTM |
MemberAuthor
Trott commented Feb 10, 2016
Unrelated known-ish flaky being addressed in another issue (and hopefully soon a PR), but otherwise, everything is OK. |
Trott added a commit to Trott/io.js that referenced this pull request Feb 10, 2016
The comments make the config hard to scan. They do not provide any information that isn't in the documentation links referred to in comments (that are not being removed here). Additionally, all rule config sections are alphabetically ordered for easier scanning etc. PR-URL: nodejs#5151 Reviewed-By: Roman Reiss <[email protected]>
MemberAuthor
Trott commented Feb 10, 2016
Landed in 783a563 |
rvagg pushed a commit that referenced this pull request Feb 15, 2016
The comments make the config hard to scan. They do not provide any information that isn't in the documentation links referred to in comments (that are not being removed here). Additionally, all rule config sections are alphabetically ordered for easier scanning etc. PR-URL: #5151 Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
The comments make the config hard to scan. They do not provide any information that isn't in the documentation links referred to in comments (that are not being removed here). Additionally, all rule config sections are alphabetically ordered for easier scanning etc. PR-URL: #5151 Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
The comments make the config hard to scan. They do not provide any information that isn't in the documentation links referred to in comments (that are not being removed here). Additionally, all rule config sections are alphabetically ordered for easier scanning etc. PR-URL: #5151 Reviewed-By: Roman Reiss <[email protected]>
Merged
stefanmb pushed a commit to stefanmb/node that referenced this pull request Feb 23, 2016
The comments make the config hard to scan. They do not provide any information that isn't in the documentation links referred to in comments (that are not being removed here). Additionally, all rule config sections are alphabetically ordered for easier scanning etc. PR-URL: nodejs#5151 Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
The comments make the config hard to scan. They do not provide any information that isn't in the documentation links referred to in comments (that are not being removed here). Additionally, all rule config sections are alphabetically ordered for easier scanning etc. PR-URL: #5151 Reviewed-By: Roman Reiss <[email protected]>
This was referenced Apr 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is on top of #5135 and should not be landed until that PR lands.
The comments make the config hard to scan. They do not provide any
information that isn't in the documentation links referred to in
comments (that are not being removed here).
Additionally, all rule config sections are alphabetically ordered for
easier scanning etc.
/cc @silverwind