Skip to content

doc: fix dns.lookup and dnsPromises.lookup description#51517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 10 commits into from
Jan 30, 2024
Merged

doc: fix dns.lookup and dnsPromises.lookup description #51517

aduh95 merged 10 commits into from
Jan 30, 2024

Conversation

@duncanchiu409
Copy link
Contributor

@duncanchiu409duncanchiu409 commented Jan 18, 2024

Fixes: #51482
Continue on: #51483

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 18, 2024

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Jan 18, 2024
ShogunPanda
ShogunPanda requested changes Jan 19, 2024
View reviewed changes
duncanchiu409and others added 3 commits January 26, 2024 14:18
@duncanchiu409@ShogunPanda
Update doc/api/dns.md
fa94817
Co-authored-by: Paolo Insogna <[email protected]>
@duncanchiu409@ShogunPanda
Update doc/api/dns.md
6c1e119
Co-authored-by: Paolo Insogna <[email protected]>
@duncanchiu409@ShogunPanda
Update doc/api/dns.md
03da199
Co-authored-by: Paolo Insogna <[email protected]>
ShogunPanda
ShogunPanda requested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@ShogunPandaShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things are pointed out in #51517 (comment).
After that, it LGTM!

mcollina
mcollina approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

duncanchiu409and others added 2 commits January 27, 2024 15:28
@duncanchiu409@ShogunPanda
Update doc/api/dns.md
78af021
Co-authored-by: Paolo Insogna <[email protected]>
@duncanchiu409@ShogunPanda
Update doc/api/dns.md
a1951a5
Co-authored-by: Paolo Insogna <[email protected]>
lpinca
lpinca reviewed Jan 27, 2024
View reviewed changes
@duncanchiu409@lpinca
Update dns.md
6eeae0f
Co-authored-by: Luigi Pinca <[email protected]>
@aduh95
Copy link
Contributor

aduh95 commented Jan 29, 2024

Linter is failing

@duncanchiu409
Copy link
ContributorAuthor

duncanchiu409 commented Jan 29, 2024•
edited
Loading

Is there something similar to lint --fix ? Is it make format-md?

aduh95
aduh95 previously approved these changes Jan 30, 2024
View reviewed changes
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2024
@aduh95aduh95 dismissed their stale reviewJanuary 30, 2024 01:18

Wrong button

@aduh95aduh95 merged commit 0f461aa into nodejs:mainJan 30, 2024
@aduh95
Copy link
Contributor

aduh95 commented Jan 30, 2024

Landed in 0f461aa

@duncanchiu409
Copy link
ContributorAuthor

duncanchiu409 commented Jan 30, 2024

Thanks to all for the work & take attention to my PR.

@domdomegg
Copy link
Contributor

domdomegg commented Feb 3, 2024

This isn't correct, as dicussed in #51482 and #51483 (comment)

We either need to make sure node actually has this behaviour, or revert this docs commit as this is taking it from ambigious to wrong :/

@domdomeggdomdomegg mentioned this pull request Feb 3, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
@duncanchiu409@rdw-msft
doc: fix dns.lookup and dnsPromises.lookup description
126a6c3
PR-URL: nodejs#51517Fixes: nodejs#51482 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
@duncanchiu409@targos
doc: fix dns.lookup and dnsPromises.lookup description
8c0a257
PR-URL: #51517Fixes: #51482 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@duncanchiu409@marco-ippolito
doc: fix dns.lookup and dnsPromises.lookup description
2126e53
PR-URL: nodejs#51517Fixes: nodejs#51482 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@duncanchiu409@richardlau
doc: fix dns.lookup and dnsPromises.lookup description
2d98906
PR-URL: #51517Fixes: #51482 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@duncanchiu409@richardlau
doc: fix dns.lookup and dnsPromises.lookup description
1dae187
PR-URL: #51517Fixes: #51482 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca left review comments

@mcollinamcollinamcollina approved these changes

@ShogunPandaShogunPandaShogunPanda approved these changes

@aduh95aduh95aduh95 left review comments

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dnsIssues and PRs related to the dns subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: dns docs for family = 0 and all = true is potentially misleading

7 participants

@duncanchiu409@nodejs-github-bot@aduh95@domdomegg@mcollina@ShogunPanda@lpinca