Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
v21.6.1 proposal#51530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v21.6.1 proposal #51530
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This reverts commit 4d3923a. PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: #51530
254b8cd to 7f9a864CompareRafaelGSS commented Jan 19, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mcollina left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: #51530
7f9a864 to 3dc0e49Comparenodejs-github-bot commented Jan 20, 2024 • edited by RafaelGSS
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by RafaelGSS
Uh oh!
There was an error while loading. Please reload this page.
RafaelGSS commented Jan 21, 2024
@anonrig can you dismiss the review? |
RafaelGSS commented Jan 22, 2024
FWIW Release is blocked because we are facing a problem with macOS binaries. |
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: #51530
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: nodejs#51530
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: nodejs#51530
2024-01-22, Version 21.6.1 (Current), @RafaelGSS
Notable Changes
This release fixes a bug in
undiciusing WebStreamsCommits
662ac95729] - Revert "stream: fix cloned webstreams not being unref'd" (Matteo Collina) #514911b8bba8aee] - test: add regression test for 51586 (Matteo Collina) #51491